Re: [PATCH v3 6/7] usb: gadget: atmel: Add attach/detach support

2024-07-24 Thread Mattijs Korpershoek
On mar., juil. 23, 2024 at 15:36, Marek Vasut wrote: > On 7/23/24 3:18 PM, Zixun LI wrote: >> Add controller attach/detach support by using >> usb_gadget_ops.pullup() method. > > It is called 'function' in C, not 'method'. I think 'method' is C++ or > maybe Java ? Agreed, 'function' is more app

Re: [PATCH v3 6/7] usb: gadget: atmel: Add attach/detach support

2024-07-24 Thread Mattijs Korpershoek
Hi Zixun, Thank you for the patch. On mar., juil. 23, 2024 at 15:18, Zixun LI wrote: > Add controller attach/detach support by using > usb_gadget_ops.pullup() method. > > Signed-off-by: Zixun LI Reviewed-by: Mattijs Korpershoek > --- > drivers/usb/gadget/atmel_usba_udc.c | 18 +

Re: [PATCH v3 6/7] usb: gadget: atmel: Add attach/detach support

2024-07-23 Thread Marek Vasut
On 7/23/24 3:18 PM, Zixun LI wrote: Add controller attach/detach support by using usb_gadget_ops.pullup() method. It is called 'function' in C, not 'method'. I think 'method' is C++ or maybe Java ? In any case: Reviewed-by: Marek Vasut Thanks !

[PATCH v3 6/7] usb: gadget: atmel: Add attach/detach support

2024-07-23 Thread Zixun LI
Add controller attach/detach support by using usb_gadget_ops.pullup() method. Signed-off-by: Zixun LI --- drivers/usb/gadget/atmel_usba_udc.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c index e