Re: [PATCH v3 5/6] mmc: actions: add MMC driver for Actions OWL S700/S900

2021-03-01 Thread Jaehoon Chung
On 3/2/21 8:04 AM, Andre Przywara wrote: > On Tue, 2 Mar 2021 07:11:54 +0900 > Jaehoon Chung wrote: > >> On 3/1/21 11:25 PM, Andre Przywara wrote: >>> On Mon, 1 Mar 2021 18:47:26 +0530 >>> Amit Tomar wrote: >>> >>> Hi, >>> > So this whole mode handling here looks dodgy. Below you mix "ass

Re: [PATCH v3 5/6] mmc: actions: add MMC driver for Actions OWL S700/S900

2021-03-01 Thread Andre Przywara
On Tue, 2 Mar 2021 07:11:54 +0900 Jaehoon Chung wrote: > On 3/1/21 11:25 PM, Andre Przywara wrote: > > On Mon, 1 Mar 2021 18:47:26 +0530 > > Amit Tomar wrote: > > > > Hi, > > > >>> So this whole mode handling here looks dodgy. Below you mix "assignments > >>> to mode" with "ORing in values",

Re: [PATCH v3 5/6] mmc: actions: add MMC driver for Actions OWL S700/S900

2021-03-01 Thread Jaehoon Chung
On 3/1/21 11:25 PM, Andre Przywara wrote: > On Mon, 1 Mar 2021 18:47:26 +0530 > Amit Tomar wrote: > > Hi, > >>> So this whole mode handling here looks dodgy. Below you mix "assignments >>> to mode" with "ORing in values", without actually ever initialising mode >>> explicitly. I wonder why the c

Re: [PATCH v3 5/6] mmc: actions: add MMC driver for Actions OWL S700/S900

2021-03-01 Thread Andre Przywara
On Mon, 1 Mar 2021 18:47:26 +0530 Amit Tomar wrote: Hi, > > So this whole mode handling here looks dodgy. Below you mix "assignments > > to mode" with "ORing in values", without actually ever initialising mode > > explicitly. I wonder why the compiler doesn't warn about this, I can see > > paths

Re: [PATCH v3 5/6] mmc: actions: add MMC driver for Actions OWL S700/S900

2021-03-01 Thread Amit Tomar
Hi, > So this whole mode handling here looks dodgy. Below you mix "assignments > to mode" with "ORing in values", without actually ever initialising mode > explicitly. I wonder why the compiler doesn't warn about this, I can see > paths were you OR into an uninitialised value. > > But the compile

Re: [PATCH v3 5/6] mmc: actions: add MMC driver for Actions OWL S700/S900

2021-01-18 Thread André Przywara
On 16/01/2021 18:32, Amit Singh Tomar wrote: > From: Amit Singh Tomar Hi, > This commit adds support for MMC controllers found on Actions OWL > SoC platform(S700/S900). > > Signed-off-by: Amit Singh Tomar > --- > Changes since v2: > * Progammed read/write delays as suggested by >

[PATCH v3 5/6] mmc: actions: add MMC driver for Actions OWL S700/S900

2021-01-16 Thread Amit Singh Tomar
From: Amit Singh Tomar This commit adds support for MMC controllers found on Actions OWL SoC platform(S700/S900). Signed-off-by: Amit Singh Tomar --- Changes since v2: * Progammed read/write delays as suggested by Jaehoon, its more readable now. * Updated commit messag