Re: [PATCH v3 4/4] arm: kirkwood: Pogoplug-V4 : Add board implementation files

2022-01-21 Thread Tony Dinh
Hi Stefan, On Wed, Jan 19, 2022 at 3:23 PM Tony Dinh wrote: > > fHi Stefan, > > On Wed, Jan 19, 2022 at 6:37 AM Stefan Roese wrote: > > > > Hi Tony, > > > > On 1/19/22 02:31, Tony Dinh wrote: > > > > > > > > >>> +#if defined(CONFIG_RESET_PHY_R) > > >>> +/* Configure and initialize PHY */ > > >>

Re: [PATCH v3 4/4] arm: kirkwood: Pogoplug-V4 : Add board implementation files

2022-01-19 Thread Tony Dinh
fHi Stefan, On Wed, Jan 19, 2022 at 6:37 AM Stefan Roese wrote: > > Hi Tony, > > On 1/19/22 02:31, Tony Dinh wrote: > > > > >>> +#if defined(CONFIG_RESET_PHY_R) > >>> +/* Configure and initialize PHY */ > >>> +void reset_phy(void) > >>> +{ > >>> + u16 reg; > >>> + int phyaddr; > >>> +

Re: [PATCH v3 4/4] arm: kirkwood: Pogoplug-V4 : Add board implementation files

2022-01-19 Thread Stefan Roese
Hi Tony, On 1/19/22 02:31, Tony Dinh wrote: +#if defined(CONFIG_RESET_PHY_R) +/* Configure and initialize PHY */ +void reset_phy(void) +{ + u16 reg; + int phyaddr; + char *name = "ethernet-controller@72000"; + char *eth0_path = "/ocp@f100/ethernet-controller@72000"; + +

Re: [PATCH v3 4/4] arm: kirkwood: Pogoplug-V4 : Add board implementation files

2022-01-18 Thread Tony Dinh
Hi Stefan, On Mon, Jan 17, 2022 at 11:54 PM Stefan Roese wrote: > > On 1/18/22 07:58, Tony Dinh wrote: > > Note: currently the fdt_get_phy_addr function in this file is > > duplicate in this board and many other Kirkwood boards > > (eg. Sheevaplug, GoFlex Home, etc.). This function is being > > f

Re: [PATCH v3 4/4] arm: kirkwood: Pogoplug-V4 : Add board implementation files

2022-01-17 Thread Stefan Roese
On 1/18/22 07:58, Tony Dinh wrote: Note: currently the fdt_get_phy_addr function in this file is duplicate in this board and many other Kirkwood boards (eg. Sheevaplug, GoFlex Home, etc.). This function is being factored out into common area by another patch. And because it was written for flattr

[PATCH v3 4/4] arm: kirkwood: Pogoplug-V4 : Add board implementation files

2022-01-17 Thread Tony Dinh
Note: currently the fdt_get_phy_addr function in this file is duplicate in this board and many other Kirkwood boards (eg. Sheevaplug, GoFlex Home, etc.). This function is being factored out into common area by another patch. And because it was written for flattree only, the patch is being rewritten