Re: [PATCH v3 29/29] acpi: Add an acpi command

2020-04-03 Thread Andy Shevchenko
On Tue, Mar 31, 2020 at 07:14:18PM +0100, Leif Lindholm wrote: > On Mon, Mar 30, 2020 at 17:13:05 -0600, Simon Glass wrote: > > +static void list_fact(struct acpi_fadt *fadt) > > Hmm, should this function be called list_facp or list_fadt? > (The wonder that is the table called FADT with the marke

Re: [PATCH v3 29/29] acpi: Add an acpi command

2020-04-03 Thread Andy Shevchenko
On Mon, Mar 30, 2020 at 05:13:05PM -0600, Simon Glass wrote: > It is useful to dump ACPI tables in U-Boot to see what has been generated. > Add a command to handle this. > > To allow the command to find the tables, add a position into the global > data. > > Support subcommands to list and dump th

Re: [PATCH v3 29/29] acpi: Add an acpi command

2020-03-31 Thread Leif Lindholm
On Mon, Mar 30, 2020 at 17:13:05 -0600, Simon Glass wrote: > It is useful to dump ACPI tables in U-Boot to see what has been generated. > Add a command to handle this. > > To allow the command to find the tables, add a position into the global > data. > > Support subcommands to list and dump the

[PATCH v3 29/29] acpi: Add an acpi command

2020-03-30 Thread Simon Glass
It is useful to dump ACPI tables in U-Boot to see what has been generated. Add a command to handle this. To allow the command to find the tables, add a position into the global data. Support subcommands to list and dump the tables. Signed-off-by: Simon Glass Reviewed-by: Wolfgang Wallner ---