Re: [PATCH v3 2/3] efi_firmware: set EFI capsule dfu_alt_info env explicitly

2025-02-26 Thread Ilias Apalodimas
Hi Jonathan, Apologies for the late reply On Mon, 24 Feb 2025 at 04:38, Jon Humphreys wrote: [...] > >> + > >> +ret = fit_update(image); > > > >> + > >> +if (env_set("dfu_alt_info", orig_dfu_env)) { > >> +log_err("unable to set env variable \"dfu_alt_info\"!\n"); > >> +

Re: [PATCH v3 2/3] efi_firmware: set EFI capsule dfu_alt_info env explicitly

2025-02-23 Thread Jon Humphreys
Ilias Apalodimas writes: > Hi Jonathan, > > The patch looks correct but there's a few more things to address. > > On Thu, Feb 13, 2025 at 01:53:50PM -0600, Jonathan Humphreys wrote: >> The current implementation of EFI capsule update uses set_dfu_alt_info() to >> set the dfu_alt_info environment

Re: [PATCH v3 2/3] efi_firmware: set EFI capsule dfu_alt_info env explicitly

2025-02-17 Thread Ilias Apalodimas
Hi Jonathan, The patch looks correct but there's a few more things to address. On Thu, Feb 13, 2025 at 01:53:50PM -0600, Jonathan Humphreys wrote: > The current implementation of EFI capsule update uses set_dfu_alt_info() to > set the dfu_alt_info environment variable with the settings it requir

Re: [PATCH v3 2/3] efi_firmware: set EFI capsule dfu_alt_info env explicitly

2025-02-14 Thread Mattijs Korpershoek
Hi Jon, Thank you for the patch. On jeu., févr. 13, 2025 at 13:53, Jonathan Humphreys wrote: > The current implementation of EFI capsule update uses set_dfu_alt_info() to > set the dfu_alt_info environment variable with the settings it requires. > However, set_dfu_alt_info() is doing this for a

[PATCH v3 2/3] efi_firmware: set EFI capsule dfu_alt_info env explicitly

2025-02-13 Thread Jonathan Humphreys
The current implementation of EFI capsule update uses set_dfu_alt_info() to set the dfu_alt_info environment variable with the settings it requires. However, set_dfu_alt_info() is doing this for all DFU operations, even those unrelated to capsule update. Thus other uses of DFU, such as DFU boot wh