Re: [PATCH v3 2/2] cmd: acpi: fix acpi list command

2023-11-20 Thread Andy Shevchenko
On Mon, Nov 20, 2023 at 01:34:22PM +0100, Heinrich Schuchardt wrote: > On 11/20/23 12:28, Andy Shevchenko wrote: > > On Sat, Nov 18, 2023 at 11:52:48PM +0100, Heinrich Schuchardt wrote: ... > > (Side question: Do you use --histogram when preparing patches? if no, try > > it.) > > Thanks for rev

Re: [PATCH v3 2/2] cmd: acpi: fix acpi list command

2023-11-20 Thread Heinrich Schuchardt
On 11/20/23 12:28, Andy Shevchenko wrote: On Sat, Nov 18, 2023 at 11:52:48PM +0100, Heinrich Schuchardt wrote: ACPI tables may comprise either RSDT, XSDT, or both. The current code fails to check the presence of the RSDT table before accessing it. This leads to an exception if the RSDT table is

Re: [PATCH v3 2/2] cmd: acpi: fix acpi list command

2023-11-20 Thread Andy Shevchenko
On Sat, Nov 18, 2023 at 11:52:48PM +0100, Heinrich Schuchardt wrote: > ACPI tables may comprise either RSDT, XSDT, or both. The current code fails > to check the presence of the RSDT table before accessing it. This leads to > an exception if the RSDT table is not provided. > > The XSDT table takes

Re: [PATCH v3 2/2] cmd: acpi: fix acpi list command

2023-11-18 Thread Simon Glass
On Sat, 18 Nov 2023 at 15:54, Heinrich Schuchardt wrote: > > ACPI tables may comprise either RSDT, XSDT, or both. The current code fails > to check the presence of the RSDT table before accessing it. This leads to > an exception if the RSDT table is not provided. > > The XSDT table takes precedenc

[PATCH v3 2/2] cmd: acpi: fix acpi list command

2023-11-18 Thread Heinrich Schuchardt
ACPI tables may comprise either RSDT, XSDT, or both. The current code fails to check the presence of the RSDT table before accessing it. This leads to an exception if the RSDT table is not provided. The XSDT table takes precedence over the RSDT table. The return values of list_rsdt() and list_rsd