Re: [PATCH v3 17/23] ns16550: match when to define bdf with uart code

2023-05-10 Thread Tom Rini
On Wed, May 10, 2023 at 03:05:38PM -0700, Troy Kisky wrote: > Hi Tom, > > You are looking at an old patch, here's the new. It was the new one, sorry, I just edited out NOCHECK at least for now. > > commit c969bedb9cb6029360e6fe7e25a331680fabe3ee > Author: Troy Kisky > Date: Thu Feb 23 08:01:

Re: [PATCH v3 17/23] ns16550: match when to define bdf with uart code

2023-05-10 Thread Troy Kisky
Hi Tom, You are looking at an old patch, here's the new. commit c969bedb9cb6029360e6fe7e25a331680fabe3ee Author: Troy Kisky Date: Thu Feb 23 08:01:46 2023 -0800 ns16550: match when to define bdf with uart code When switching defined(CONFIG_PCI) to CONFIG_IS_ENABLED(PCI) bdf is no

Re: [PATCH v3 17/23] ns16550: match when to define bdf with uart code

2023-05-10 Thread Tom Rini
On Wed, May 10, 2023 at 02:46:14PM -0600, Simon Glass wrote: > Hi Tom, > > On Wed, 10 May 2023 at 14:41, Tom Rini wrote: > > > > On Mon, Mar 13, 2023 at 02:31:39PM -0700, Troy Kisky wrote: > > > > > When switching defined(CONFIG_PCI) to CONFIG_IS_ENABLED(PCI) > > > bdf is no longer accessible. So

Re: [PATCH v3 17/23] ns16550: match when to define bdf with uart code

2023-05-10 Thread Simon Glass
Hi Tom, On Wed, 10 May 2023 at 14:41, Tom Rini wrote: > > On Mon, Mar 13, 2023 at 02:31:39PM -0700, Troy Kisky wrote: > > > When switching defined(CONFIG_PCI) to CONFIG_IS_ENABLED(PCI) > > bdf is no longer accessible. So add preprocessor protection > > to avoid access. > > > > Signed-off-by: Troy

Re: [PATCH v3 17/23] ns16550: match when to define bdf with uart code

2023-05-10 Thread Tom Rini
On Mon, Mar 13, 2023 at 02:31:39PM -0700, Troy Kisky wrote: > When switching defined(CONFIG_PCI) to CONFIG_IS_ENABLED(PCI) > bdf is no longer accessible. So add preprocessor protection > to avoid access. > > Signed-off-by: Troy Kisky > Reviewed-by: Simon Glass > --- > > (no changes since v2) >

[PATCH v3 17/23] ns16550: match when to define bdf with uart code

2023-03-13 Thread Troy Kisky
When switching defined(CONFIG_PCI) to CONFIG_IS_ENABLED(PCI) bdf is no longer accessible. So add preprocessor protection to avoid access. Signed-off-by: Troy Kisky Reviewed-by: Simon Glass --- (no changes since v2) Changes in v2: - changed condition of when to include field bdf - added protect