Re: [PATCH v3 1/7] rpi5: add initial memory map for bcm2712

2023-12-20 Thread Ivan T . Ivanov
Hi, On 12-18 23:03, Ivan T. Ivanov wrote: > > +static struct mm_region bcm2712_mem_map[MEM_MAP_MAX_ENTRIES] = { > + { > + .virt = 0xUL, > + .phys = 0xUL, > + .size = 0x3f80UL, Something that I realized just now. This memory map is vali

Re: [PATCH v3 1/7] rpi5: add initial memory map for bcm2712

2023-12-20 Thread Ivan T. Ivanov
On 12-19 21:45, Simon Glass wrote: > > > > +static struct mm_region bcm2712_mem_map[MEM_MAP_MAX_ENTRIES] = { > > Would it be possible to read these from the devicetree? If there is a devicetree passed, yes, it will be possible. I have not done this just because I can't test all possible combinati

Re: [PATCH v3 1/7] rpi5: add initial memory map for bcm2712

2023-12-19 Thread Simon Glass
Hi Ivan, On Mon, 18 Dec 2023 at 14:04, Ivan T. Ivanov wrote: > > From: Dmitry Malkin > > includes: > * 1GB of RAM (from 4GB or 8GB total) > * VPU memory interface > * AXI ranges (main peripherals) > > Signed-off-by: Dmitry Malkin > Signed-off-by: Ivan T. Ivanov > --- > arch/arm/mach-bcm283x/i

Re: [PATCH v3 1/7] rpi5: add initial memory map for bcm2712

2023-12-19 Thread Ivan T. Ivanov
On 12-18 23:25, Stefan Wahren wrote: > > > > +static struct mm_region bcm2712_mem_map[MEM_MAP_MAX_ENTRIES] = { > > + { > in comparison to mach-imx/imx9/soc.c most of the memory maps doesn't > have a describing comment. Yep, I have thinking to add more comments, but decided to not modify too muc

Re: [PATCH v3 1/7] rpi5: add initial memory map for bcm2712

2023-12-18 Thread Stefan Wahren
Hi Ivan, Am 18.12.23 um 22:03 schrieb Ivan T. Ivanov: From: Dmitry Malkin includes: * 1GB of RAM (from 4GB or 8GB total) * VPU memory interface * AXI ranges (main peripherals) my experience with U-Boot is little, but i do my best to give you some feedback. Signed-off-by: Dmitry Malkin Sign

[PATCH v3 1/7] rpi5: add initial memory map for bcm2712

2023-12-18 Thread Ivan T. Ivanov
From: Dmitry Malkin includes: * 1GB of RAM (from 4GB or 8GB total) * VPU memory interface * AXI ranges (main peripherals) Signed-off-by: Dmitry Malkin Signed-off-by: Ivan T. Ivanov --- arch/arm/mach-bcm283x/init.c | 38 +++- 1 file changed, 37 insertions(+), 1