Re: [PATCH v3 1/4] fs/squashfs: Add init. and clean-up functions to decompression

Hello, In your commit title: spurious . after "init". On Tue, 18 Aug 2020 16:31:15 +0200 Joao Marcos Costa wrote: > -static struct squashfs_ctxt ctxt; > +struct squashfs_ctxt sqfs_ctxt; Why are you dropping the "static" here ? This symbol only needs to be visible from that file. If you keep th

[PATCH v3 1/4] fs/squashfs: Add init. and clean-up functions to decompression

Add sqfs_decompressor_init() and sqfs_decompressor_cleanup(). These functions are called respectively in sqfs_probe() and sqfs_close(). For now, only ZSTD requires an initialization logic. ZSTD support will be added in a follow-up commit. Move squashfs_ctxt definition to sqfs_filesystem.h. This st