Re: [PATCH v3 1/3] firmware: psci: Fix bind_smccc_features psci check

2024-02-02 Thread Igor Opaniuk
Hello Weizhao, On Fri, Feb 2, 2024 at 4:43 AM Weizhao Ouyang wrote: > > Hi Igor, > > On Thu, Feb 1, 2024 at 10:36 PM Igor Opaniuk > wrote: > > > > Hello Weizhao, > > > > On Wed, Jan 31, 2024 at 3:15 PM Weizhao Ouyang wrote: > > > > > > According to PSCI specification DEN0022F, PSCI_FEATURES is

Re: [PATCH v3 1/3] firmware: psci: Fix bind_smccc_features psci check

2024-02-01 Thread Weizhao Ouyang
Hi Igor, On Thu, Feb 1, 2024 at 10:36 PM Igor Opaniuk wrote: > > Hello Weizhao, > > On Wed, Jan 31, 2024 at 3:15 PM Weizhao Ouyang wrote: > > > > According to PSCI specification DEN0022F, PSCI_FEATURES is used to check > > whether the SMCCC is implemented by discovering SMCCC_VERSION. > > > Coul

Re: [PATCH v3 1/3] firmware: psci: Fix bind_smccc_features psci check

2024-02-01 Thread Weizhao Ouyang
Hi Abdellatif, On Thu, Feb 1, 2024 at 7:40 PM Abdellatif El Khlifi wrote: > > Hi Weizhao, > > > - if (request_psci_features(ARM_SMCCC_ARCH_FEATURES) == > > + if (request_psci_features(ARM_SMCCC_VERSION) == > > PSCI_RET_NOT_SUPPORTED) > > return 0; > > > > + if

Re: [PATCH v3 1/3] firmware: psci: Fix bind_smccc_features psci check

2024-02-01 Thread Igor Opaniuk
Hello Weizhao, On Wed, Jan 31, 2024 at 3:15 PM Weizhao Ouyang wrote: > > According to PSCI specification DEN0022F, PSCI_FEATURES is used to check > whether the SMCCC is implemented by discovering SMCCC_VERSION. > Could you please add more details to your commit message or as a comment explaining

Re: [PATCH v3 1/3] firmware: psci: Fix bind_smccc_features psci check

2024-02-01 Thread Abdellatif El Khlifi
Hi Weizhao, > - if (request_psci_features(ARM_SMCCC_ARCH_FEATURES) == > + if (request_psci_features(ARM_SMCCC_VERSION) == > PSCI_RET_NOT_SUPPORTED) > return 0; > > + if (invoke_psci_fn(ARM_SMCCC_VERSION, 0, 0, 0) < ARM_SMCCC_VERSION_1_1) > + return

[PATCH v3 1/3] firmware: psci: Fix bind_smccc_features psci check

2024-01-31 Thread Weizhao Ouyang
According to PSCI specification DEN0022F, PSCI_FEATURES is used to check whether the SMCCC is implemented by discovering SMCCC_VERSION. Signed-off-by: Weizhao Ouyang --- v3: remove fallback smc call v2: check SMCCC_ARCH_FEATURES --- drivers/firmware/psci.c | 5 - include/linux/arm-smccc.h