Re: [PATCH v3 1/3] Move bootorder and bootoption apis to lib

2023-05-16 Thread Raymond Mao
Hi Ilias, I think we can address Heinrich's comments in a follow up patch set. The concerns are more related to refactoring on the logic of existing functions and less to the functionality we want to enable with these patches. Thanks. Regards, Raymond On Tue, 16 May 2023 at 01:58, Ilias Apalodim

Re: [PATCH v3 1/3] Move bootorder and bootoption apis to lib

2023-05-15 Thread Ilias Apalodimas
Hi Raymond, Heinrichm you had some concerns on the previous version of this patchset wrt to the current code. Do you think the rework should take place here? Or are you ok in cleaning it up in a follow up series? Thanks /Ilias On Tue, May 02, 2023 at 12:12:17PM -0700, Raymond Mao wrote: > Rename

[PATCH v3 1/3] Move bootorder and bootoption apis to lib

2023-05-02 Thread Raymond Mao
Rename and move bootorder and bootoption apis from cmd to lib for re-use between eficonfig and bootmgr Signed-off-by: Raymond Mao --- Changes in v2 - Ignore EFI_NOT_FOUND returned from efi_bootmgr_update_media_device_boot_option which means no boot options scanned. Changes in v3 - Split the p