Re: [PATCH v3 04/11] imx8mp: power-domain: Don't power off pd_bus

2024-03-22 Thread Marek Vasut
On 3/22/24 5:55 AM, Sumit Garg wrote: Hi, I think if people are concerned about power consumption then it should be implemented properly in U-Boot to remove all the DT based devices before passing on control to the next stage. I would expect imx8mp_hsiomix_off() to be called either on 'usb st

Re: [PATCH v3 04/11] imx8mp: power-domain: Don't power off pd_bus

2024-03-21 Thread Sumit Garg
On Fri, 22 Mar 2024 at 00:47, Marek Vasut wrote: > > On 3/21/24 6:46 AM, Sumit Garg wrote: > > On Thu, 21 Mar 2024 at 11:06, Marek Vasut wrote: > >> > >> On 3/15/24 11:41 AM, Sumit Garg wrote: > >>> On Fri, 15 Mar 2024 at 14:53, Marek Vasut wrote: > > On 3/15/24 6:31 AM, Sumit Garg wro

Re: [PATCH v3 04/11] imx8mp: power-domain: Don't power off pd_bus

2024-03-21 Thread Marek Vasut
On 3/21/24 6:46 AM, Sumit Garg wrote: On Thu, 21 Mar 2024 at 11:06, Marek Vasut wrote: On 3/15/24 11:41 AM, Sumit Garg wrote: On Fri, 15 Mar 2024 at 14:53, Marek Vasut wrote: On 3/15/24 6:31 AM, Sumit Garg wrote: On Thu, 14 Mar 2024 at 09:45, Marek Vasut wrote: On 3/12/24 8:03 AM, Sumi

Re: [PATCH v3 04/11] imx8mp: power-domain: Don't power off pd_bus

2024-03-20 Thread Sumit Garg
On Thu, 21 Mar 2024 at 11:06, Marek Vasut wrote: > > On 3/15/24 11:41 AM, Sumit Garg wrote: > > On Fri, 15 Mar 2024 at 14:53, Marek Vasut wrote: > >> > >> On 3/15/24 6:31 AM, Sumit Garg wrote: > >>> On Thu, 14 Mar 2024 at 09:45, Marek Vasut wrote: > > On 3/12/24 8:03 AM, Sumit Garg wro

Re: [PATCH v3 04/11] imx8mp: power-domain: Don't power off pd_bus

2024-03-20 Thread Marek Vasut
On 3/15/24 11:41 AM, Sumit Garg wrote: On Fri, 15 Mar 2024 at 14:53, Marek Vasut wrote: On 3/15/24 6:31 AM, Sumit Garg wrote: On Thu, 14 Mar 2024 at 09:45, Marek Vasut wrote: On 3/12/24 8:03 AM, Sumit Garg wrote: power_domain_on/off() isn't refcounted and power domain bus shouldn't be tur

Re: [PATCH v3 04/11] imx8mp: power-domain: Don't power off pd_bus

2024-03-20 Thread Sumit Garg
Gentle ping.. On Fri, 15 Mar 2024 at 16:11, Sumit Garg wrote: > > On Fri, 15 Mar 2024 at 14:53, Marek Vasut wrote: > > > > On 3/15/24 6:31 AM, Sumit Garg wrote: > > > On Thu, 14 Mar 2024 at 09:45, Marek Vasut wrote: > > >> > > >> On 3/12/24 8:03 AM, Sumit Garg wrote: > > >>> power_domain_on/off

Re: [PATCH v3 04/11] imx8mp: power-domain: Don't power off pd_bus

2024-03-15 Thread Sumit Garg
On Fri, 15 Mar 2024 at 14:53, Marek Vasut wrote: > > On 3/15/24 6:31 AM, Sumit Garg wrote: > > On Thu, 14 Mar 2024 at 09:45, Marek Vasut wrote: > >> > >> On 3/12/24 8:03 AM, Sumit Garg wrote: > >>> power_domain_on/off() isn't refcounted and power domain bus shouldn't be > >>> turned off for a sin

Re: [PATCH v3 04/11] imx8mp: power-domain: Don't power off pd_bus

2024-03-15 Thread Marek Vasut
On 3/15/24 6:31 AM, Sumit Garg wrote: On Thu, 14 Mar 2024 at 09:45, Marek Vasut wrote: On 3/12/24 8:03 AM, Sumit Garg wrote: power_domain_on/off() isn't refcounted and power domain bus shouldn't be turned off for a single peripheral domain as it would negatively affect other peripheral domain

Re: [PATCH v3 04/11] imx8mp: power-domain: Don't power off pd_bus

2024-03-14 Thread Sumit Garg
On Thu, 14 Mar 2024 at 09:45, Marek Vasut wrote: > > On 3/12/24 8:03 AM, Sumit Garg wrote: > > power_domain_on/off() isn't refcounted and power domain bus shouldn't be > > turned off for a single peripheral domain as it would negatively affect > > other peripheral domains. So lets just skip turnin

Re: [PATCH v3 04/11] imx8mp: power-domain: Don't power off pd_bus

2024-03-13 Thread Marek Vasut
On 3/12/24 8:03 AM, Sumit Garg wrote: power_domain_on/off() isn't refcounted and power domain bus shouldn't be turned off for a single peripheral domain as it would negatively affect other peripheral domains. So lets just skip turning off bus power domain. What exactly is the issue and how did

[PATCH v3 04/11] imx8mp: power-domain: Don't power off pd_bus

2024-03-12 Thread Sumit Garg
power_domain_on/off() isn't refcounted and power domain bus shouldn't be turned off for a single peripheral domain as it would negatively affect other peripheral domains. So lets just skip turning off bus power domain. Fixes: 898e7610c62a ("imx: power-domain: Add i.MX8MP HSIOMIX driver") Signed-of