Re: [PATCH v3 03/36] mmc: msm_sdhci: use modern clock handling

2024-02-01 Thread Sumit Garg
On Thu, 1 Feb 2024 at 20:04, Caleb Connolly wrote: > > > > On 01/02/2024 08:19, Sumit Garg wrote: > > On Tue, 30 Jan 2024 at 19:35, Caleb Connolly > > wrote: > >> > >> Use the clk_* helper functions and the correct property name for clocks. > > > > This still doesn't handle fixed clocks like in

Re: [PATCH v3 03/36] mmc: msm_sdhci: use modern clock handling

2024-02-01 Thread Caleb Connolly
On 01/02/2024 08:19, Sumit Garg wrote: > On Tue, 30 Jan 2024 at 19:35, Caleb Connolly > wrote: >> >> Use the clk_* helper functions and the correct property name for clocks. > > This still doesn't handle fixed clocks like in case of QCS404, upstream DT > says: > > sdcc1: mmc

Re: [PATCH v3 03/36] mmc: msm_sdhci: use modern clock handling

2024-02-01 Thread Sumit Garg
On Tue, 30 Jan 2024 at 19:35, Caleb Connolly wrote: > > Use the clk_* helper functions and the correct property name for clocks. This still doesn't handle fixed clocks like in case of QCS404, upstream DT says: sdcc1: mmc@7804000 { compatible = "qcom,qcs404

Re: [PATCH v3 03/36] mmc: msm_sdhci: use modern clock handling

2024-01-30 Thread Dan Carpenter
On Tue, Jan 30, 2024 at 02:04:51PM +, Caleb Connolly wrote: > + > + /* The clock is already enabled by the clk_bulk above */ > + ret = clk_set_rate(&prv->clks.clks[i], clk_rate); > + if (!ret) { > + printf("Couldn't set core clock rate: %d\n", ret); > + retur

[PATCH v3 03/36] mmc: msm_sdhci: use modern clock handling

2024-01-30 Thread Caleb Connolly
Use the clk_* helper functions and the correct property name for clocks. Reviewed-by: Neil Armstrong Signed-off-by: Caleb Connolly --- drivers/mmc/msm_sdhci.c | 69 - 1 file changed, 46 insertions(+), 23 deletions(-) diff --git a/drivers/mmc/msm_