Re: [PATCH v3] x86: Change tesing logic of mtrr commit

2023-07-31 Thread Bin Meng
On Mon, Jul 31, 2023 at 9:56 PM Simon Glass wrote: > > From: Bin Meng > > On Coral U-Boot SPL programs some MTRRs and FSPv2 in U-Boot proper > needs to program MTRRs too. With current testing logic of mtrr > commit in init_cache_f_r(), the mtrr commit is skipped which won't > work as the queued m

Re: [PATCH v3] x86: Change tesing logic of mtrr commit

2023-07-31 Thread Bin Meng
Hi Simon, On Tue, Aug 1, 2023 at 12:13 AM Simon Glass wrote: > > Hi Bin, > > On Mon, 31 Jul 2023 at 08:58, Bin Meng wrote: > > > > Hi Simon, > > > > On Mon, Jul 31, 2023 at 9:56 PM Simon Glass wrote: > > > > > > From: Bin Meng > > > > > > On Coral U-Boot SPL programs some MTRRs and FSPv2 in U-

Re: [PATCH v3] x86: Change tesing logic of mtrr commit

2023-07-31 Thread Simon Glass
Hi Bin, On Mon, 31 Jul 2023 at 08:58, Bin Meng wrote: > > Hi Simon, > > On Mon, Jul 31, 2023 at 9:56 PM Simon Glass wrote: > > > > From: Bin Meng > > > > On Coral U-Boot SPL programs some MTRRs and FSPv2 in U-Boot proper > > needs to program MTRRs too. With current testing logic of mtrr > > com

Re: [PATCH v3] x86: Change tesing logic of mtrr commit

2023-07-31 Thread Bin Meng
Hi Simon, On Mon, Jul 31, 2023 at 9:56 PM Simon Glass wrote: > > From: Bin Meng > > On Coral U-Boot SPL programs some MTRRs and FSPv2 in U-Boot proper > needs to program MTRRs too. With current testing logic of mtrr > commit in init_cache_f_r(), the mtrr commit is skipped which won't > work as t

[PATCH v3] x86: Change tesing logic of mtrr commit

2023-07-31 Thread Simon Glass
From: Bin Meng On Coral U-Boot SPL programs some MTRRs and FSPv2 in U-Boot proper needs to program MTRRs too. With current testing logic of mtrr commit in init_cache_f_r(), the mtrr commit is skipped which won't work as the queued mtrr requests include setup for DRAM regions. Change the logic to