Re: [PATCH v3] efi_loader: check tcg2 protocol installation outside the TCG protocol

2021-11-28 Thread Ilias Apalodimas
Hi Kojima-san [...] > > > +efi_status_t efi_tcg2_do_initial_measurement(void) > > > +{ > > > + efi_status_t ret; > > > + struct udevice *dev; > > > + > > > + ret = platform_get_tpm2_device(&dev); > > > + if (ret != EFI_SUCCESS) > > > + goto out; > > > + > > > + ret

Re: [PATCH v3] efi_loader: check tcg2 protocol installation outside the TCG protocol

2021-11-28 Thread Masahisa Kojima
Hi Ilias, On Fri, 26 Nov 2021 at 23:55, Ilias Apalodimas wrote: > > Hi Kojima-san, > > On Fri, Nov 26, 2021 at 10:31:16AM +0900, Masahisa Kojima wrote: > > There are functions that calls tcg2_agile_log_append() outside > > of the TCG protocol invocation (e.g tcg2_measure_pe_image). > > These func

Re: [PATCH v3] efi_loader: check tcg2 protocol installation outside the TCG protocol

2021-11-26 Thread Ilias Apalodimas
Hi Kojima-san, On Fri, Nov 26, 2021 at 10:31:16AM +0900, Masahisa Kojima wrote: > There are functions that calls tcg2_agile_log_append() outside > of the TCG protocol invocation (e.g tcg2_measure_pe_image). > These functions must to check that tcg2 protocol is installed. > If not, measurement shal

[PATCH v3] efi_loader: check tcg2 protocol installation outside the TCG protocol

2021-11-25 Thread Masahisa Kojima
There are functions that calls tcg2_agile_log_append() outside of the TCG protocol invocation (e.g tcg2_measure_pe_image). These functions must to check that tcg2 protocol is installed. If not, measurement shall be skipped. Together with above change, this commit also removes the unnecessary tcg2_