Re: [PATCH v2 4/9] bootstd: Rename bootdev_setup_sibling_blk()

2023-08-03 Thread Bin Meng
On Tue, Aug 1, 2023 at 1:23 AM Mattijs Korpershoek wrote: > > On dim., juil. 30, 2023 at 11:15, Simon Glass wrote: > > > This name is a little confusing since it suggests that it sets up the > > sibling block device. In fact it sets up a bootdev for it. Rename the > > function to make this cleare

Re: [PATCH v2 4/9] bootstd: Rename bootdev_setup_sibling_blk()

2023-07-31 Thread Mattijs Korpershoek
On dim., juil. 30, 2023 at 11:15, Simon Glass wrote: > This name is a little confusing since it suggests that it sets up the > sibling block device. In fact it sets up a bootdev for it. Rename the > function to make this clearer. > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek

Re: [PATCH v2 4/9] bootstd: Rename bootdev_setup_sibling_blk()

2023-07-30 Thread Bin Meng
On Mon, Jul 31, 2023 at 1:15 AM Simon Glass wrote: > > This name is a little confusing since it suggests that it sets up the > sibling block device. In fact it sets up a bootdev for it. Rename the > function to make this clearer. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Fix the

[PATCH v2 4/9] bootstd: Rename bootdev_setup_sibling_blk()

2023-07-30 Thread Simon Glass
This name is a little confusing since it suggests that it sets up the sibling block device. In fact it sets up a bootdev for it. Rename the function to make this clearer. Signed-off-by: Simon Glass --- Changes in v2: - Fix the function name in the header as well boot/bootdev-uclass.c