Re: [PATCH v2 4/6] power: pmic: sunxi: add AXP717 SPL support

2024-07-15 Thread Ryan Walklin
On Mon, 15 Jul 2024, at 11:38 AM, Andre Przywara wrote: > On Sun, 14 Jul 2024 20:20:44 +1200 > "Ryan Walklin" wrote: > > Hi Ryan, > > I consider the fact that the AXP209 and the AXP717 use the same I2C > address a sheer coincidence, so would like to keep the code readable > and maintainable. This

Re: [PATCH v2 4/6] power: pmic: sunxi: add AXP717 SPL support

2024-07-14 Thread Andre Przywara
On Sun, 14 Jul 2024 20:20:44 +1200 "Ryan Walklin" wrote: Hi Ryan, > On Sat, 13 Jul 2024, at 4:53 AM, Andre Przywara wrote: > > > #define AXP209_I2C_ADDR0x34 > > +#define AXP717_I2C_ADDR0x34 > > > > #define AXP305_I2C_ADDR0x36 > > #

Re: [PATCH v2 4/6] power: pmic: sunxi: add AXP717 SPL support

2024-07-14 Thread Ryan Walklin
Hi Andre, On Sat, 13 Jul 2024, at 4:53 AM, Andre Przywara wrote: > #define AXP209_I2C_ADDR 0x34 > +#define AXP717_I2C_ADDR 0x34 > > #define AXP305_I2C_ADDR 0x36 > #define AXP313_I2C_ADDR 0x36 > @@ -36,6 +37,8

[PATCH v2 4/6] power: pmic: sunxi: add AXP717 SPL support

2024-07-12 Thread Andre Przywara
On boards using the AXP717 PMIC, the DRAM rail is often not setup correctly at reset time, so we have to program the PMIC very early in the SPL, before running the DRAM initialisation. Using the new generic AXP SPL driver, add the Kconfig options and platform bits needed to support an AXP717 PMIC