Re: [PATCH v2 21/50] hash: Drop some #ifdefs in hash.c

2021-05-14 Thread Tom Rini
On Fri, May 14, 2021 at 10:37:54AM -0500, Alex G. wrote: > > > On 5/6/21 9:24 AM, Simon Glass wrote: > > We can use the __maybe_unused attribute to avoid some of the #ifdefs in > > this file. Update the functions accordingly. > > What is __maybe_unused? Does u-boot support booting quantum comput

Re: [PATCH v2 21/50] hash: Drop some #ifdefs in hash.c

2021-05-14 Thread Alex G.
On 5/6/21 9:24 AM, Simon Glass wrote: We can use the __maybe_unused attribute to avoid some of the #ifdefs in this file. Update the functions accordingly. What is __maybe_unused? Does u-boot support booting quantum computers? Note: The actual hashing interface is still a mess, with four s

[PATCH v2 21/50] hash: Drop some #ifdefs in hash.c

2021-05-06 Thread Simon Glass
We can use the __maybe_unused attribute to avoid some of the #ifdefs in this file. Update the functions accordingly. Note: The actual hashing interface is still a mess, with four separate combinations and lots of #ifdefs. This should really use a driver approach, e.g. as is done with partition dri