Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-24 Thread Tom Rini
On Sun, Jun 23, 2024 at 03:52:12PM -0600, Simon Glass wrote: > Hi Tom, > > On Fri, 21 Jun 2024 at 16:12, Tom Rini wrote: > > > > On Fri, Jun 21, 2024 at 01:38:07PM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Fri, 21 Jun 2024 at 13:19, Tom Rini wrote: > > > > > > > > On Fri, Jun 21, 20

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-23 Thread Simon Glass
Hi Tom, On Fri, 21 Jun 2024 at 16:12, Tom Rini wrote: > > On Fri, Jun 21, 2024 at 01:38:07PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Fri, 21 Jun 2024 at 13:19, Tom Rini wrote: > > > > > > On Fri, Jun 21, 2024 at 11:55:42AM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Fri

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-21 Thread Tom Rini
On Fri, Jun 21, 2024 at 01:38:07PM -0600, Simon Glass wrote: > Hi Tom, > > On Fri, 21 Jun 2024 at 13:19, Tom Rini wrote: > > > > On Fri, Jun 21, 2024 at 11:55:42AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Fri, 21 Jun 2024 at 10:05, Tom Rini wrote: > > [snip] > > > > Yes, I very muc

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-21 Thread Simon Glass
Hi Tom, On Fri, 21 Jun 2024 at 13:19, Tom Rini wrote: > > On Fri, Jun 21, 2024 at 11:55:42AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Fri, 21 Jun 2024 at 10:05, Tom Rini wrote: > [snip] > > > Yes, I very much do not like guessing about 3 numbers instead of > > > guessing about 1 number a

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-21 Thread Tom Rini
On Fri, Jun 21, 2024 at 11:55:42AM -0600, Simon Glass wrote: > Hi Tom, > > On Fri, 21 Jun 2024 at 10:05, Tom Rini wrote: [snip] > > Yes, I very much do not like guessing about 3 numbers instead of > > guessing about 1 number and using the standard mechanism we already > > have. Please use BOARD_S

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-21 Thread Simon Glass
Hi Tom, On Fri, 21 Jun 2024 at 10:05, Tom Rini wrote: > > On Fri, Jun 21, 2024 at 08:57:51AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Thu, 20 Jun 2024 at 17:19, Tom Rini wrote: > > > > > > On Thu, Jun 20, 2024 at 05:05:29PM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Wed

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-21 Thread Tom Rini
On Fri, Jun 21, 2024 at 08:57:51AM -0600, Simon Glass wrote: > Hi Tom, > > On Thu, 20 Jun 2024 at 17:19, Tom Rini wrote: > > > > On Thu, Jun 20, 2024 at 05:05:29PM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Wed, 19 Jun 2024 at 09:32, Tom Rini wrote: > > > > > > > > On Tue, Jun 18, 20

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-21 Thread Simon Glass
Hi Tom, On Thu, 20 Jun 2024 at 17:19, Tom Rini wrote: > > On Thu, Jun 20, 2024 at 05:05:29PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 19 Jun 2024 at 09:32, Tom Rini wrote: > > > > > > On Tue, Jun 18, 2024 at 09:03:37PM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Tue

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-20 Thread Tom Rini
On Thu, Jun 20, 2024 at 05:05:29PM -0600, Simon Glass wrote: > Hi Tom, > > On Wed, 19 Jun 2024 at 09:32, Tom Rini wrote: > > > > On Tue, Jun 18, 2024 at 09:03:37PM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 18 Jun 2024 at 08:15, Tom Rini wrote: > > > > > > > > On Tue, Jun 18, 20

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-20 Thread Simon Glass
Hi Tom, On Wed, 19 Jun 2024 at 09:32, Tom Rini wrote: > > On Tue, Jun 18, 2024 at 09:03:37PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 18 Jun 2024 at 08:15, Tom Rini wrote: > > > > > > On Tue, Jun 18, 2024 at 06:43:51AM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Mon

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-19 Thread Tom Rini
On Tue, Jun 18, 2024 at 09:03:37PM -0600, Simon Glass wrote: > Hi Tom, > > On Tue, 18 Jun 2024 at 08:15, Tom Rini wrote: > > > > On Tue, Jun 18, 2024 at 06:43:51AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 17 Jun 2024 at 11:16, Tom Rini wrote: > > > > > > > > On Mon, Jun 17, 20

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-18 Thread Simon Glass
Hi Tom, On Tue, 18 Jun 2024 at 08:15, Tom Rini wrote: > > On Tue, Jun 18, 2024 at 06:43:51AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 17 Jun 2024 at 11:16, Tom Rini wrote: > > > > > > On Mon, Jun 17, 2024 at 07:53:22AM -0600, Simon Glass wrote: > > > > Hi, > > > > > > > > On Sat, 15

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-18 Thread Tom Rini
On Tue, Jun 18, 2024 at 06:43:51AM -0600, Simon Glass wrote: > Hi Tom, > > On Mon, 17 Jun 2024 at 11:16, Tom Rini wrote: > > > > On Mon, Jun 17, 2024 at 07:53:22AM -0600, Simon Glass wrote: > > > Hi, > > > > > > On Sat, 15 Jun 2024 at 01:03, Ilias Apalodimas > > > wrote: > > > > > > > > Hi Heinr

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-18 Thread Simon Glass
Hi Tom, On Mon, 17 Jun 2024 at 11:16, Tom Rini wrote: > > On Mon, Jun 17, 2024 at 07:53:22AM -0600, Simon Glass wrote: > > Hi, > > > > On Sat, 15 Jun 2024 at 01:03, Ilias Apalodimas > > wrote: > > > > > > Hi Heinrich > > > > > > resending the reply, I accidentally sent half of the message... > >

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-17 Thread Tom Rini
On Mon, Jun 17, 2024 at 07:53:22AM -0600, Simon Glass wrote: > Hi, > > On Sat, 15 Jun 2024 at 01:03, Ilias Apalodimas > wrote: > > > > Hi Heinrich > > > > resending the reply, I accidentally sent half of the message... > > > > On Fri, 14 Jun 2024 at 12:04, Heinrich Schuchardt > > wrote: > > > >

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-17 Thread Simon Glass
Hi, On Sat, 15 Jun 2024 at 01:03, Ilias Apalodimas wrote: > > Hi Heinrich > > resending the reply, I accidentally sent half of the message... > > On Fri, 14 Jun 2024 at 12:04, Heinrich Schuchardt wrote: > > > > On 14.06.24 09:01, Ilias Apalodimas wrote: > > > On Fri, 14 Jun 2024 at 09:59, Heinri

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-15 Thread Ilias Apalodimas
Hi Heinrich resending the reply, I accidentally sent half of the message... On Fri, 14 Jun 2024 at 12:04, Heinrich Schuchardt wrote: > > On 14.06.24 09:01, Ilias Apalodimas wrote: > > On Fri, 14 Jun 2024 at 09:59, Heinrich Schuchardt > > wrote: > >> > >> On 6/14/24 08:03, Ilias Apalodimas wrot

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-15 Thread Ilias Apalodimas
Hi Heinrich, On Fri, 14 Jun 2024 at 12:04, Heinrich Schuchardt wrote: > > On 14.06.24 09:01, Ilias Apalodimas wrote: > > On Fri, 14 Jun 2024 at 09:59, Heinrich Schuchardt > > wrote: > >> > >> On 6/14/24 08:03, Ilias Apalodimas wrote: > >>> Hi Simon, > >>> > >>> On Mon, 10 Jun 2024 at 17:59, Si

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-14 Thread Heinrich Schuchardt
On 14.06.24 09:01, Ilias Apalodimas wrote: On Fri, 14 Jun 2024 at 09:59, Heinrich Schuchardt wrote: On 6/14/24 08:03, Ilias Apalodimas wrote: Hi Simon, On Mon, 10 Jun 2024 at 17:59, Simon Glass wrote: It does not make sense to enable all SHA algorithms unless they are needed. It bloats th

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-14 Thread Ilias Apalodimas
On Fri, 14 Jun 2024 at 09:59, Heinrich Schuchardt wrote: > > On 6/14/24 08:03, Ilias Apalodimas wrote: > > Hi Simon, > > > > On Mon, 10 Jun 2024 at 17:59, Simon Glass wrote: > >> > >> It does not make sense to enable all SHA algorithms unless they are > >> needed. It bloats the code and in this c

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-14 Thread Heinrich Schuchardt
On 6/14/24 08:03, Ilias Apalodimas wrote: Hi Simon, On Mon, 10 Jun 2024 at 17:59, Simon Glass wrote: It does not make sense to enable all SHA algorithms unless they are needed. It bloats the code and in this case, causes chromebook_link to fail to build. That board does use the TPM, but not w

Re: [PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-13 Thread Ilias Apalodimas
Hi Simon, On Mon, 10 Jun 2024 at 17:59, Simon Glass wrote: > > It does not make sense to enable all SHA algorithms unless they are > needed. It bloats the code and in this case, causes chromebook_link to > fail to build. That board does use the TPM, but not with measured boot, > nor EFI. > > Sinc

[PATCH v2 2/9] tpm: Avoid code bloat when not using EFI_TCG2_PROTOCOL

2024-06-10 Thread Simon Glass
It does not make sense to enable all SHA algorithms unless they are needed. It bloats the code and in this case, causes chromebook_link to fail to build. That board does use the TPM, but not with measured boot, nor EFI. Since EFI_TCG2_PROTOCOL already selects these options, we just need to add the