Re: [PATCH v2 2/6] x86: fsp: Use mtrr_set_next_var() for graphics memory

2023-07-31 Thread Simon Glass
On Mon, 31 Jul 2023 at 00:02, Bin Meng wrote: > > From: Bin Meng > > At present this uses mtrr_add_request() & mtrr_commit() combination > to program the MTRR for graphics memory. This usage has two major > issues as below: > > - mtrr_commit() will re-initialize all MTRR registers from index 0, >

Re: [PATCH v2 2/6] x86: fsp: Use mtrr_set_next_var() for graphics memory

2023-07-31 Thread Bin Meng
Hi Simon, On Mon, Jul 31, 2023 at 2:02 PM Bin Meng wrote: > > From: Bin Meng > > At present this uses mtrr_add_request() & mtrr_commit() combination > to program the MTRR for graphics memory. This usage has two major > issues as below: > > - mtrr_commit() will re-initialize all MTRR registers fr

[PATCH v2 2/6] x86: fsp: Use mtrr_set_next_var() for graphics memory

2023-07-30 Thread Bin Meng
From: Bin Meng At present this uses mtrr_add_request() & mtrr_commit() combination to program the MTRR for graphics memory. This usage has two major issues as below: - mtrr_commit() will re-initialize all MTRR registers from index 0, using the settings previously added by mtrr_add_request() an