Re: [PATCH v2 2/2] watchdog: qcom: improve driver with more functionality

2025-04-22 Thread Paul Sajna
Tested stop and start in the console with reset (service watchdog) commented out and ensured start eventually reset from the watchdog. All seems good. Squashed and preparing to push v3. On Tuesday, April 22nd, 2025 at 3:46 PM, Paul Sajna wrote: > > > I tested reset and stop pretty thoroughly

Re: [PATCH v2 2/2] watchdog: qcom: improve driver with more functionality

2025-04-22 Thread Casey Connolly
Hi Paul, Please squash this patch into the first one, otherwise this looks good. Did you test start/stop/reset? Kind regards, On 4/22/25 01:20, Paul Sajna wrote: - add the ability to start the watchdog - add the ability to reset the watchdog - remove the automatic disable in the probe functi

Re: [PATCH v2 2/2] watchdog: qcom: improve driver with more functionality

2025-04-22 Thread Paul Sajna
I tested reset and stop pretty thoroughly. I suppose "start" could use some more checking. I'll squash and fix a line of code I noticed I accidentally duplicated, then retest that this evening (Pacific Time) On Tuesday, April 22nd, 2025 at 12:50 PM, Casey Connolly wrote: > > > Hi Paul, > >

[PATCH v2 2/2] watchdog: qcom: improve driver with more functionality

2025-04-21 Thread Paul Sajna
- add the ability to start the watchdog - add the ability to reset the watchdog - remove the automatic disable in the probe function - use log macros for errors Signed-off-by: Paul Sajna --- drivers/watchdog/qcom-wdt.c | 32 +--- 1 file changed, 25 insertions(+), 7 de