Re: [PATCH v2 2/2] pwm: Add a driver for Chrome OS EC PWM

2020-09-27 Thread Simon Glass
On Sat, 26 Sep 2020 at 14:09, Alper Nebi Yasak wrote: > > This PWM is used in rk3399-gru-bob and rk3399-gru-kevin to control > the display brightness. We can only change the duty cycle, so on > set_config() we just try to match the duty cycle that dividing duty_ns > by period_ns gives us. To disab

Re: [PATCH v2 2/2] pwm: Add a driver for Chrome OS EC PWM

2020-09-27 Thread Alper Nebi Yasak
On 27/09/2020 12:29, Arnaud Patard (Rtp) wrote: > Peter Robinson writes: >> A quick look at the Linux DT for the GRU Chromebooks and it looks like >> the panels are also attached via EDP like on the Pinebook Pro so this >> patch series adding initial support for the rk3399 EDP might be of use >> h

Re: [PATCH v2 2/2] pwm: Add a driver for Chrome OS EC PWM

2020-09-27 Thread Rtp
Peter Robinson writes: > On Sat, Sep 26, 2020 at 9:09 PM Alper Nebi Yasak > wrote: >> >> This PWM is used in rk3399-gru-bob and rk3399-gru-kevin to control >> the display brightness. We can only change the duty cycle, so on >> set_config() we just try to match the duty cycle that dividing duty_n

Re: [PATCH v2 2/2] pwm: Add a driver for Chrome OS EC PWM

2020-09-27 Thread Peter Robinson
On Sat, Sep 26, 2020 at 9:09 PM Alper Nebi Yasak wrote: > > This PWM is used in rk3399-gru-bob and rk3399-gru-kevin to control > the display brightness. We can only change the duty cycle, so on > set_config() we just try to match the duty cycle that dividing duty_ns > by period_ns gives us. To dis

[PATCH v2 2/2] pwm: Add a driver for Chrome OS EC PWM

2020-09-26 Thread Alper Nebi Yasak
This PWM is used in rk3399-gru-bob and rk3399-gru-kevin to control the display brightness. We can only change the duty cycle, so on set_config() we just try to match the duty cycle that dividing duty_ns by period_ns gives us. To disable, we set the duty cycle to zero while keeping the old value for