Re: [PATCH v2 15/18] fdt: Allow the devicetree to come from a bloblist

2023-12-08 Thread Raymond Mao
Hi Simon, OK, I can try to remove them into two series. Regards, Raymond On Thu, 7 Dec 2023 at 22:14, Simon Glass wrote: > Hi Raymond, > > On Wed, 6 Dec 2023 at 13:35, Raymond Mao wrote: > > > > Hi Simon, > > > > > The other thing missing here is SPL. The bloblist is designed such > > > that i

Re: [PATCH v2 15/18] fdt: Allow the devicetree to come from a bloblist

2023-12-07 Thread Simon Glass
Hi Raymond, On Wed, 6 Dec 2023 at 13:35, Raymond Mao wrote: > > Hi Simon, > > > The other thing missing here is SPL. The bloblist is designed such > > that it can be set up in any phase of U-Boot, then is passed to > > following phases. So using IS_ENABLED(BLOBLIST) doesn't do what we > > need. A

Re: [PATCH v2 15/18] fdt: Allow the devicetree to come from a bloblist

2023-12-06 Thread Raymond Mao
Hi Simon, > The other thing missing here is SPL. The bloblist is designed such > that it can be set up in any phase of U-Boot, then is passed to > following phases. So using IS_ENABLED(BLOBLIST) doesn't do what we > need. As I noted, it breaks sandbox_spl. What happens if a board wants > to use bl

Re: [PATCH v2 15/18] fdt: Allow the devicetree to come from a bloblist

2023-12-06 Thread Ilias Apalodimas
Hi Simon, On Wed, 6 Dec 2023 at 05:57, Simon Glass wrote: > > Hi Ilias, > > On Mon, 4 Dec 2023 at 23:22, Ilias Apalodimas > wrote: > > > > Hi Simon, > > > > We did discuss this in OSFC but perhaps you forgot. The discussion > > was based on the mail here [0]. > > Perhaps I did? Or perhaps we ha

Re: [PATCH v2 15/18] fdt: Allow the devicetree to come from a bloblist

2023-12-05 Thread Simon Glass
Hi Ilias, On Mon, 4 Dec 2023 at 23:22, Ilias Apalodimas wrote: > > Hi Simon, > > We did discuss this in OSFC but perhaps you forgot. The discussion > was based on the mail here [0]. Perhaps I did? Or perhaps we had a different understanding of it? > > On Tue, 5 Dec 2023 at 02:52, Simon Glass

Re: [PATCH v2 15/18] fdt: Allow the devicetree to come from a bloblist

2023-12-04 Thread Ilias Apalodimas
Hi Simon, We did discuss this in OSFC but perhaps you forgot. The discussion was based on the mail here [0]. On Tue, 5 Dec 2023 at 02:52, Simon Glass wrote: > > Hi Raymond, > > On Mon, 4 Dec 2023 at 12:25, Raymond Mao wrote: > > > > Hi Simon, > > > > When `OF_BOARD` is defined, the FDT should

Re: [PATCH v2 15/18] fdt: Allow the devicetree to come from a bloblist

2023-12-04 Thread Simon Glass
Hi Raymond, On Mon, 4 Dec 2023 at 12:25, Raymond Mao wrote: > > Hi Simon, > > When `OF_BOARD` is defined, the FDT should be from one of the board-specific > mechanisms: > 1. FDT from a bloblist via boot args > 2. FDT in memory > I don't think we need a new build option to distinguish these two,

Re: [PATCH v2 15/18] fdt: Allow the devicetree to come from a bloblist

2023-12-04 Thread Raymond Mao
Hi Simon, When `OF_BOARD` is defined, the FDT should be from one of the board-specific mechanisms: 1. FDT from a bloblist via boot args 2. FDT in memory I don't think we need a new build option to distinguish these two, since it can be done in runtime by checking whether the boot args follow the F

Re: [PATCH v2 15/18] fdt: Allow the devicetree to come from a bloblist

2023-12-02 Thread Simon Glass
Hi Raymond, On Mon, 27 Nov 2023 at 12:53, Raymond Mao wrote: > > From: Simon Glass > > Standard passage provides for a bloblist to be passed from one firmware > phase to the next. That can be used to pass the devicetree along as well. > If CONFIG_OF_BOARD is defined, a board custom routine will

[PATCH v2 15/18] fdt: Allow the devicetree to come from a bloblist

2023-11-27 Thread Raymond Mao
From: Simon Glass Standard passage provides for a bloblist to be passed from one firmware phase to the next. That can be used to pass the devicetree along as well. If CONFIG_OF_BOARD is defined, a board custom routine will provide a bloblist or a specified memory address to retrieve the devicetre