Re: [PATCH v2 13/28] binman: Move section-building code into a function

2020-10-29 Thread Simon Glass
Create a new _BuildSectionData() to hold the code that is now in GetData(), so that it is clearly separated from entry.GetData() base function. Separate out the 'pad-before' processing to make this easier to understand. Unfortunately this breaks the testDual test. Rather than squash several patch

[PATCH v2 13/28] binman: Move section-building code into a function

2020-10-26 Thread Simon Glass
Create a new _BuildSectionData() to hold the code that is now in GetData(), so that it is clearly separated from entry.GetData() base function. Separate out the 'pad-before' processing to make this easier to understand. Unfortunately this breaks the testDual test. Rather than squash several patch