Re: [PATCH v2 1/2] net: brcm: netXtreme driver

2021-10-25 Thread Roman Bacik
On Mon, Oct 25, 2021 at 3:22 PM Marek Behún wrote: > > On Mon, 25 Oct 2021 14:35:20 -0700 > Roman Bacik wrote: > > > > - you are introducing custom mechanism for setting / getting PHY > > > parameters, via custom specific env variables, for example in the > > > set_phy_speed() and set_phy_lin

Re: [PATCH v2 1/2] net: brcm: netXtreme driver

2021-10-25 Thread Marek Behún
On Mon, 25 Oct 2021 14:35:20 -0700 Roman Bacik wrote: > > - you are introducing custom mechanism for setting / getting PHY > > parameters, via custom specific env variables, for example in the > > set_phy_speed() and set_phy_link() functions, i.e.: > > sprintf(name1, "bnxt_eth%u_phy_s

Re: [PATCH v2 1/2] net: brcm: netXtreme driver

2021-10-25 Thread Roman Bacik
On Mon, Oct 25, 2021 at 6:58 AM Marek Behún wrote: > > NAK for this driver. > > - display_banner() spams the output unnecessarily, the information > should be printed with debug() We will make the change as requested. > > - you are introducing custom mechanism for setting / getting PHY > par

Re: [PATCH v2 1/2] net: brcm: netXtreme driver

2021-10-25 Thread Marek Behún
NAK for this driver. - display_banner() spams the output unnecessarily, the information should be printed with debug() - you are introducing custom mechanism for setting / getting PHY parameters, via custom specific env variables, for example in the set_phy_speed() and set_phy_link() functi

[PATCH v2 1/2] net: brcm: netXtreme driver

2021-10-22 Thread Roman Bacik
From: Bharat Gooty Broadcom bnxt L2 driver support. Used by the Broadcom iproc platforms. Signed-off-by: Bharat Gooty Reviewed-by: Ramon Fried Signed-off-by: Roman Bacik --- Changes in v2: - rebase and remove DM_PCI dependency from BNXT_ETH - remove tautology assignment from debug_resp()