Re: [PATCH v2 1/2] lib: uuid: use RNG device if present

2021-01-20 Thread Matthias Brugger
On Wed, Jan 20, 2021 at 12:50:56PM -0700, Simon Glass wrote: > Hi Matthias, > > On Wed, 20 Jan 2021 at 04:17, Matthias Brugger wrote: > > > > > > > > On 29/12/2020 04:32, Simon Glass wrote: > > > Hi guys, > > > > > > On Wed, 23 Dec 2020 at 03:24, Torsten Duwe wrote: > > >> > > >> On Sun, 20 Dec

Re: [PATCH v2 1/2] lib: uuid: use RNG device if present

2021-01-20 Thread Simon Glass
Hi Matthias, On Wed, 20 Jan 2021 at 04:17, Matthias Brugger wrote: > > > > On 29/12/2020 04:32, Simon Glass wrote: > > Hi guys, > > > > On Wed, 23 Dec 2020 at 03:24, Torsten Duwe wrote: > >> > >> On Sun, 20 Dec 2020 11:17:50 -0700 > >> Simon Glass wrote: > >> > >>> Hi Torsten, > >>> > >>> On Su

Re: [PATCH v2 1/2] lib: uuid: use RNG device if present

2021-01-20 Thread Matthias Brugger
On 29/12/2020 04:32, Simon Glass wrote: > Hi guys, > > On Wed, 23 Dec 2020 at 03:24, Torsten Duwe wrote: >> >> On Sun, 20 Dec 2020 11:17:50 -0700 >> Simon Glass wrote: >> >>> Hi Torsten, >>> >>> On Sun, 20 Dec 2020 at 10:00, Torsten Duwe wrote: On Fri, 18 Dec 2020 19:29:12 -0700 >>

Re: [PATCH v2 1/2] lib: uuid: use RNG device if present

2020-12-28 Thread Simon Glass
Hi guys, On Wed, 23 Dec 2020 at 03:24, Torsten Duwe wrote: > > On Sun, 20 Dec 2020 11:17:50 -0700 > Simon Glass wrote: > > > Hi Torsten, > > > > On Sun, 20 Dec 2020 at 10:00, Torsten Duwe wrote: > > > > > > On Fri, 18 Dec 2020 19:29:12 -0700 > > > Simon Glass wrote: > > > > > > > > - int

Re: [PATCH v2 1/2] lib: uuid: use RNG device if present

2020-12-23 Thread Torsten Duwe
On Sun, 20 Dec 2020 11:17:50 -0700 Simon Glass wrote: > Hi Torsten, > > On Sun, 20 Dec 2020 at 10:00, Torsten Duwe wrote: > > > > On Fri, 18 Dec 2020 19:29:12 -0700 > > Simon Glass wrote: > > > > > > - int i; > > > > - > > > > - srand(get_ticks() + rand()); > > > > + int i, r

Re: [PATCH v2 1/2] lib: uuid: use RNG device if present

2020-12-23 Thread Matthias Brugger
Hi Simon, On 19/12/2020 03:29, Simon Glass wrote: > Hi Mattias, > > On Wed, 16 Dec 2020 at 09:28, wrote: >> >> From: Matthias Brugger >> >> When calculating a random UUID we use a weak seed. >> Use a RNG device if present to increase entropy. >> >> Signed-off-by: Matthias Brugger >> >> --- >>

Re: [PATCH v2 1/2] lib: uuid: use RNG device if present

2020-12-20 Thread Simon Glass
Hi Torsten, On Sun, 20 Dec 2020 at 10:00, Torsten Duwe wrote: > > On Fri, 18 Dec 2020 19:29:12 -0700 > Simon Glass wrote: > > > > - int i; > > > - > > > - srand(get_ticks() + rand()); > > > + int i, ret; > > > + struct udevice *devp; > > > + u8 randv = 0; > > > + >

Re: [PATCH v2 1/2] lib: uuid: use RNG device if present

2020-12-20 Thread Torsten Duwe
On Fri, 18 Dec 2020 19:29:12 -0700 Simon Glass wrote: > > - int i; > > - > > - srand(get_ticks() + rand()); > > + int i, ret; > > + struct udevice *devp; > > + u8 randv = 0; > > + > > +#if defined(CONFIG_DM_RNG) > > This seems a little backwards to me. The caller sh

Re: [PATCH v2 1/2] lib: uuid: use RNG device if present

2020-12-18 Thread Simon Glass
Hi Mattias, On Wed, 16 Dec 2020 at 09:28, wrote: > > From: Matthias Brugger > > When calculating a random UUID we use a weak seed. > Use a RNG device if present to increase entropy. > > Signed-off-by: Matthias Brugger > > --- > > Changes in v2: > - fix dm_rng_read() parameters > - add missing i

Re: [PATCH v2 1/2] lib: uuid: use RNG device if present

2020-12-18 Thread mbrugger
On Fri, Dec 18, 2020 at 09:37:28AM +0100, Torsten Duwe wrote: > On Wed, 16 Dec 2020 17:28:06 +0100 > matthias@kernel.org wrote: > > > @@ -249,9 +251,22 @@ void gen_rand_uuid(unsigned char *uuid_bin) > > { > > u32 ptr[4]; > > struct uuid *uuid = (struct uuid *)ptr; > > - int i; > > -

Re: [PATCH v2 1/2] lib: uuid: use RNG device if present

2020-12-18 Thread Torsten Duwe
On Wed, 16 Dec 2020 17:28:06 +0100 matthias@kernel.org wrote: > @@ -249,9 +251,22 @@ void gen_rand_uuid(unsigned char *uuid_bin) > { > u32 ptr[4]; > struct uuid *uuid = (struct uuid *)ptr; > - int i; > - > - srand(get_ticks() + rand()); > + int i, ret; > + struct u

[PATCH v2 1/2] lib: uuid: use RNG device if present

2020-12-16 Thread matthias . bgg
From: Matthias Brugger When calculating a random UUID we use a weak seed. Use a RNG device if present to increase entropy. Signed-off-by: Matthias Brugger --- Changes in v2: - fix dm_rng_read() parameters - add missing include lib/uuid.c | 21 ++--- 1 file changed, 18 insert