Re: [PATCH v2 1/2] efi_loader: fix set_capsule_result()

2021-06-30 Thread AKASHI Takahiro
On Thu, Jul 01, 2021 at 03:20:48AM +0200, Heinrich Schuchardt wrote: > Am 1. Juli 2021 02:49:09 MESZ schrieb AKASHI Takahiro > : > >NAK. For example, > >On Wed, Jun 30, 2021 at 05:31:15PM +0200, Heinrich Schuchardt wrote: > >> The log category must be LOG_CATEGORY LOGC_EFI. This one above and

Re: [PATCH v2 1/2] efi_loader: fix set_capsule_result()

2021-06-30 Thread Heinrich Schuchardt
Am 1. Juli 2021 02:49:09 MESZ schrieb AKASHI Takahiro : >NAK. > >On Wed, Jun 30, 2021 at 05:31:15PM +0200, Heinrich Schuchardt wrote: >> The log category must be LOG_CATEGORY LOGC_EFI. >> >> efi_set_variable() should be called with EFI_CALL(). Use >> efi_set_variable_int() instead. >> >> A log t

Re: [PATCH v2 1/2] efi_loader: fix set_capsule_result()

2021-06-30 Thread AKASHI Takahiro
NAK. On Wed, Jun 30, 2021 at 05:31:15PM +0200, Heinrich Schuchardt wrote: > The log category must be LOG_CATEGORY LOGC_EFI. > > efi_set_variable() should be called with EFI_CALL(). Use > efi_set_variable_int() instead. > > A log text "Updating ..." if SetVariable() fails does not make sense for

[PATCH v2 1/2] efi_loader: fix set_capsule_result()

2021-06-30 Thread Heinrich Schuchardt
The log category must be LOG_CATEGORY LOGC_EFI. efi_set_variable() should be called with EFI_CALL(). Use efi_set_variable_int() instead. A log text "Updating ..." if SetVariable() fails does not make sense for a variable that is not required to be preexisting. CapsuleLast should always be immedi