Re: [PATCH v2 1/2] cli: Correct several bugs in cli_getch()

2023-02-06 Thread Simon Glass
Hi Heinrich, On Mon, 6 Feb 2023 at 15:18, Heinrich Schuchardt wrote: > > On 2/6/23 18:12, Simon Glass wrote: > > Hi Heinrich, > > > > On Sun, 5 Feb 2023 at 14:29, Heinrich Schuchardt wrote: > >> > >> > >> > >> Am 5. Februar 2023 03:08:54 MEZ schrieb Simon Glass : > >>> This function does not beh

Re: [PATCH v2 1/2] cli: Correct several bugs in cli_getch()

2023-02-06 Thread Heinrich Schuchardt
On 2/6/23 18:12, Simon Glass wrote: Hi Heinrich, On Sun, 5 Feb 2023 at 14:29, Heinrich Schuchardt wrote: Am 5. Februar 2023 03:08:54 MEZ schrieb Simon Glass : This function does not behave as expected when unknown escape sequences are sent to it: - it fails to store (and thus echo) the la

Re: [PATCH v2 1/2] cli: Correct several bugs in cli_getch()

2023-02-06 Thread Simon Glass
Hi Heinrich, On Sun, 5 Feb 2023 at 14:29, Heinrich Schuchardt wrote: > > > > Am 5. Februar 2023 03:08:54 MEZ schrieb Simon Glass : > >This function does not behave as expected when unknown escape sequences > >are sent to it: > > > >- it fails to store (and thus echo) the last character of the inv

Re: [PATCH v2 1/2] cli: Correct several bugs in cli_getch()

2023-02-05 Thread Heinrich Schuchardt
Am 5. Februar 2023 03:08:54 MEZ schrieb Simon Glass : >This function does not behave as expected when unknown escape sequences >are sent to it: > >- it fails to store (and thus echo) the last character of the invalid > sequence What would be the benefit of echoing it? Is there any reason to as

[PATCH v2 1/2] cli: Correct several bugs in cli_getch()

2023-02-04 Thread Simon Glass
This function does not behave as expected when unknown escape sequences are sent to it: - it fails to store (and thus echo) the last character of the invalid sequence - it fails to set esc_len to 0 when it finishes emitting the invalid sequence, meaning that the following character will appear