Re: [PATCH v2] spl: Add callback for preprocessing loaded FIT header before parsing

2021-03-30 Thread Philippe REYNES
Hi Farhan, Le 30/03/2021 à 01:10, Farhan Ali a écrit : Phillipe, In our implementation we store our binaries outside the FIT header, and introduce a gap between the header and the start of binary data (-p and -E option in mkimage). After the FIT has been generated, we sign the FIT header and

Re: [PATCH v2] spl: Add callback for preprocessing loaded FIT header before parsing

2021-03-29 Thread Farhan Ali
Phillipe, In our implementation we store our binaries outside the FIT header, and introduce a gap between the header and the start of binary data (-p and -E option in mkimage). After the FIT has been generated, we sign the FIT header and insert the signature into this gap. The weak function then c

Re: [PATCH v2] spl: Add callback for preprocessing loaded FIT header before parsing

2021-03-24 Thread Simon Glass
Hi Philippe, On Wed, 24 Mar 2021 at 06:16, Philippe REYNES wrote: > > Hi Simon and Alex, > > Le 23/03/2021 à 01:56, Simon Glass a écrit : > > Hi Alex, > > > > On Tue, 23 Mar 2021 at 04:12, Alex G. wrote: > >> On 3/22/21 9:27 AM, Philippe REYNES wrote: > >>> Hi all, > >>> > >>> > >>> Le 11/03/202

Re: [PATCH v2] spl: Add callback for preprocessing loaded FIT header before parsing

2021-03-23 Thread Philippe REYNES
Hi Simon and Alex, Le 23/03/2021 à 01:56, Simon Glass a écrit : Hi Alex, On Tue, 23 Mar 2021 at 04:12, Alex G. wrote: On 3/22/21 9:27 AM, Philippe REYNES wrote: Hi all, Le 11/03/2021 à 00:10, Alex G a écrit : [snip] I reach the same issue, my customers are also worried with the actual si

Re: [PATCH v2] spl: Add callback for preprocessing loaded FIT header before parsing

2021-03-22 Thread Simon Glass
Hi Alex, On Tue, 23 Mar 2021 at 04:12, Alex G. wrote: > > On 3/22/21 9:27 AM, Philippe REYNES wrote: > > Hi all, > > > > > > Le 11/03/2021 à 00:10, Alex G a écrit : > [snip] > > > > I reach the same issue, my customers are also worried with the actual > > signature check scheme on u-boot. > > The

Re: [PATCH v2] spl: Add callback for preprocessing loaded FIT header before parsing

2021-03-22 Thread Alex G.
On 3/22/21 9:27 AM, Philippe REYNES wrote: Hi all, Le 11/03/2021 à 00:10, Alex G a écrit : [snip] I reach the same issue, my customers are also worried with the actual signature check scheme on u-boot. The fit data/node are parsed before being checked : data should be used only after being

Re: [PATCH v2] spl: Add callback for preprocessing loaded FIT header before parsing

2021-03-22 Thread Philippe REYNES
Hi all, Le 11/03/2021 à 00:10, Alex G a écrit : On 3/10/21 2:49 PM, Farhan Ali wrote: On Wed, Mar 10, 2021 at 11:38 AM Alex G. This patch describes "how" you're trying to achieve it, but "what" you     want to achieve. I'll get later into why I think the "how" is     fundamentally flawed. The

Re: [PATCH v2] spl: Add callback for preprocessing loaded FIT header before parsing

2021-03-10 Thread Farhan Ali
On Wed, Mar 10, 2021 at 11:38 AM Alex G. wrote: > On 3/9/21 5:55 PM, Farhan Ali wrote: > > This change adds a callback for preprocessing the FIT header before > > it is parsed. There are 3 main reasons for this callback: > > > > (1) If a vulnerability is discovered in the FIT parsing/loading code

Re: [PATCH v2] spl: Add callback for preprocessing loaded FIT header before parsing

2021-03-10 Thread Alex G
On 3/10/21 2:49 PM, Farhan Ali wrote: On Wed, Mar 10, 2021 at 11:38 AM Alex G. This patch describes "how" you're trying to achieve it, but "what" you want to achieve. I'll get later into why I think the "how" is fundamentally flawed. The 'what' is basically this: I want to be able to

Re: [PATCH v2] spl: Add callback for preprocessing loaded FIT header before parsing

2021-03-10 Thread Alex G.
On 3/9/21 5:55 PM, Farhan Ali wrote: This change adds a callback for preprocessing the FIT header before it is parsed. There are 3 main reasons for this callback: (1) If a vulnerability is discovered in the FIT parsing/loading code, or libfdt, this callback allows users to scan the FIT header fo

[PATCH v2] spl: Add callback for preprocessing loaded FIT header before parsing

2021-03-09 Thread Farhan Ali
This change adds a callback for preprocessing the FIT header before it is parsed. There are 3 main reasons for this callback: (1) If a vulnerability is discovered in the FIT parsing/loading code, or libfdt, this callback allows users to scan the FIT header for specific exploit signatures and preve