Re: [PATCH v2] spi: mvebu_a3700_spi: add support for cs-gpios

2020-09-30 Thread Stefan Roese
On 30.09.20 16:25, Hilliard, George wrote: On Sep 30, 2020, at 12:20 AM, Stefan Roese wrote: Hi George, thanks for the new version. One nitpicking comment below... On 29.09.20 20:34, George Hilliard wrote: + /* Set up CS GPIOs in device tree, if any */ + if (CONFIG_IS_ENABLED(DM_GP

Re: [PATCH v2] spi: mvebu_a3700_spi: add support for cs-gpios

2020-09-30 Thread Hilliard, George
On Sep 30, 2020, at 12:20 AM, Stefan Roese wrote: > > Hi George, > > thanks for the new version. One nitpicking comment below... > > On 29.09.20 20:34, George Hilliard wrote: >> >> + /* Set up CS GPIOs in device tree, if any */ >> + if (CONFIG_IS_ENABLED(DM_GPIO) && gpio_get_list_count

Re: [PATCH v2] spi: mvebu_a3700_spi: add support for cs-gpios

2020-09-29 Thread Stefan Roese
Hi George, thanks for the new version. One nitpicking comment below... On 29.09.20 20:34, George Hilliard wrote: The device tree has a way to specify GPIO lines as chip selects. From the binding docs: So if for example the controller has 2 CS lines, and the cs-gpios property looks l

[PATCH v2] spi: mvebu_a3700_spi: add support for cs-gpios

2020-09-29 Thread George Hilliard
The device tree has a way to specify GPIO lines as chip selects. From the binding docs: So if for example the controller has 2 CS lines, and the cs-gpios property looks like this: cs-gpios = <&gpio1 0 0> <0> <&gpio1 1 0> <&gpio1 2 0>; Then it should be configured so that num_chi