Re: [PATCH v2] sandbox: fix a compilation error

2023-07-23 Thread Simon Glass
Hi, On Tue, 13 Jun 2023 at 18:33, Tom Rini wrote: > > On Tue, Jun 13, 2023 at 07:05:52PM +0300, Sergei Antonov wrote: > > On Tue, 13 Jun 2023 at 17:58, Simon Glass wrote: > > > The problem with this is it then cannot be built on non-sandbox > > > boards. I think v1 was OK. > > > > Before the pat

Re: [PATCH v2] sandbox: fix a compilation error

2023-06-13 Thread Simon Glass
Hi, On Tue, 13 Jun 2023 at 18:33, Tom Rini wrote: > > On Tue, Jun 13, 2023 at 07:05:52PM +0300, Sergei Antonov wrote: > > On Tue, 13 Jun 2023 at 17:58, Simon Glass wrote: > > > The problem with this is it then cannot be built on non-sandbox > > > boards. I think v1 was OK. > > > > Before the pat

Re: [PATCH v2] sandbox: fix a compilation error

2023-06-13 Thread Tom Rini
On Tue, Jun 13, 2023 at 07:05:52PM +0300, Sergei Antonov wrote: > On Tue, 13 Jun 2023 at 17:58, Simon Glass wrote: > > The problem with this is it then cannot be built on non-sandbox > > boards. I think v1 was OK. > > Before the patch as well as after the patch: > if CONFIG_SANDBOX_SDL > declar

Re: [PATCH v2] sandbox: fix a compilation error

2023-06-13 Thread Sergei Antonov
On Tue, 13 Jun 2023 at 17:58, Simon Glass wrote: > The problem with this is it then cannot be built on non-sandbox > boards. I think v1 was OK. Before the patch as well as after the patch: if CONFIG_SANDBOX_SDL declaration of sandbox_sdl_set_bpp() else definition of sandbox_sdl_set_bpp() retu

Re: [PATCH v2] sandbox: fix a compilation error

2023-06-13 Thread Tom Rini
On Tue, Jun 13, 2023 at 03:58:25PM +0100, Simon Glass wrote: > Hi Sergei, > > On Mon, 12 Jun 2023 at 22:19, Sergei Antonov wrote: > > > > With sandbox and sandbox64 configurations: > > > > In file included from .../u-boot/include/test/test.h:156, > > from .../u-boot/include/test/

Re: [PATCH v2] sandbox: fix a compilation error

2023-06-13 Thread Simon Glass
Hi Sergei, On Mon, 12 Jun 2023 at 22:19, Sergei Antonov wrote: > > With sandbox and sandbox64 configurations: > > In file included from .../u-boot/include/test/test.h:156, > from .../u-boot/include/test/lib.h:9, > from .../u-boot/test/lib/test_crc8.c:8: > .../u-b

[PATCH v2] sandbox: fix a compilation error

2023-06-12 Thread Sergei Antonov
With sandbox and sandbox64 configurations: In file included from .../u-boot/include/test/test.h:156, from .../u-boot/include/test/lib.h:9, from .../u-boot/test/lib/test_crc8.c:8: .../u-boot/arch/sandbox/include/asm/test.h: In function ‘sandbox_sdl_set_bpp’: .../u-