Re: [PATCH v2] phy: Track power-on and init counts in uclass

2021-12-30 Thread Peter Robinson
On Tue, Dec 28, 2021 at 12:55 PM Tom Rini wrote: > > On Tue, Dec 28, 2021 at 01:34:18AM -0700, Simon Glass wrote: > > Hi Alper, > > > > On Fri, 24 Dec 2021 at 06:06, Alper Nebi Yasak > > wrote: > > > > > > On boards using the RK3399 SoC, the USB OHCI and EHCI controllers share > > > the same PHY

Re: [PATCH v2] phy: Track power-on and init counts in uclass

2021-12-29 Thread Simon Glass
Hi Alper, On Wed, 29 Dec 2021 at 15:01, Alper Nebi Yasak wrote: > > On 28/12/2021 11:34, Simon Glass wrote: > > Should add comments for the struct > > I can do that and send as a v3. > > > Also I wonder if a simple fixed-length array might be possible instead > > of the linked list? > > I think i

Re: [PATCH v2] phy: Track power-on and init counts in uclass

2021-12-29 Thread Alper Nebi Yasak
On 28/12/2021 16:08, Simon Glass wrote: > On Tue, 28 Dec 2021 at 05:55, Tom Rini wrote: >> Thanks for the review Simon. Since I think this should unblock some >> common hardware, does everyone think this should be safe enough to pull >> in now, or no, I shouldn't bend the rules, and take this for

Re: [PATCH v2] phy: Track power-on and init counts in uclass

2021-12-29 Thread Alper Nebi Yasak
On 28/12/2021 11:34, Simon Glass wrote: > Should add comments for the struct I can do that and send as a v3. > Also I wonder if a simple fixed-length array might be possible instead > of the linked list? I think it's possible, my first prototype was something like: #define MAX_PHYS 16 stru

Re: [PATCH v2] phy: Track power-on and init counts in uclass

2021-12-28 Thread Simon Glass
Hi Tom, On Tue, 28 Dec 2021 at 05:55, Tom Rini wrote: > > On Tue, Dec 28, 2021 at 01:34:18AM -0700, Simon Glass wrote: > > Hi Alper, > > > > On Fri, 24 Dec 2021 at 06:06, Alper Nebi Yasak > > wrote: > > > > > > On boards using the RK3399 SoC, the USB OHCI and EHCI controllers share > > > the sa

Re: [PATCH v2] phy: Track power-on and init counts in uclass

2021-12-28 Thread Tom Rini
On Tue, Dec 28, 2021 at 01:34:18AM -0700, Simon Glass wrote: > Hi Alper, > > On Fri, 24 Dec 2021 at 06:06, Alper Nebi Yasak > wrote: > > > > On boards using the RK3399 SoC, the USB OHCI and EHCI controllers share > > the same PHY device instance. While these controllers are being stopped > > the

Re: [PATCH v2] phy: Track power-on and init counts in uclass

2021-12-28 Thread Simon Glass
Hi Alper, On Fri, 24 Dec 2021 at 06:06, Alper Nebi Yasak wrote: > > On boards using the RK3399 SoC, the USB OHCI and EHCI controllers share > the same PHY device instance. While these controllers are being stopped > they both attempt to power-off and deinitialize it, but trying to > power-off the

[PATCH v2] phy: Track power-on and init counts in uclass

2021-12-24 Thread Alper Nebi Yasak
On boards using the RK3399 SoC, the USB OHCI and EHCI controllers share the same PHY device instance. While these controllers are being stopped they both attempt to power-off and deinitialize it, but trying to power-off the deinitialized PHY device results in a hang. This usually happens just befor