Re: [PATCH v2] USB: Fix NULLPTR dereference when serial# is unset

2025-01-28 Thread Marek Vasut
On 1/28/25 10:11 AM, Mattijs Korpershoek wrote: Hi Michael, Thank you for the patch. On mar., janv. 28, 2025 at 02:49, Marek Vasut wrote: On 1/28/25 1:30 AM, Michael Ferolito wrote: The current behaviour of this function will dereference a null pointer if the serial# environment variable is

Re: [PATCH v2] USB: Fix NULLPTR dereference when serial# is unset

2025-01-28 Thread Mattijs Korpershoek
Hi Michael, Thank you for the patch. On mar., janv. 28, 2025 at 02:49, Marek Vasut wrote: > On 1/28/25 1:30 AM, Michael Ferolito wrote: >> The current behaviour of this function will dereference a null pointer >> if the serial# environment variable is unset. This was discovered on a >> board wh

Re: [PATCH v2] USB: Fix NULLPTR dereference when serial# is unset

2025-01-28 Thread Mattijs Korpershoek
Hi Heiko, On mar., janv. 28, 2025 at 10:17, Heiko Schocher wrote: > Hello Mattijs, > > On 28.01.25 10:11, Mattijs Korpershoek wrote: >> Hi Michael, >> >> Thank you for the patch. >> >> On mar., janv. 28, 2025 at 02:49, Marek Vasut wrote: >> >>> On 1/28/25 1:30 AM, Michael Ferolito wrote: >>>

Re: [PATCH v2] USB: Fix NULLPTR dereference when serial# is unset

2025-01-28 Thread Heiko Schocher
Hello Mattijs, On 28.01.25 10:11, Mattijs Korpershoek wrote: Hi Michael, Thank you for the patch. On mar., janv. 28, 2025 at 02:49, Marek Vasut wrote: On 1/28/25 1:30 AM, Michael Ferolito wrote: The current behaviour of this function will dereference a null pointer if the serial# environme

Re: [PATCH v2] USB: Fix NULLPTR dereference when serial# is unset

2025-01-27 Thread Marek Vasut
On 1/28/25 1:30 AM, Michael Ferolito wrote: The current behaviour of this function will dereference a null pointer if the serial# environment variable is unset. This was discovered on a board where U-Boot did not have access to the first 256MB of ram, resulting in a board crash. In the event that

[PATCH v2] USB: Fix NULLPTR dereference when serial# is unset

2025-01-27 Thread Michael Ferolito
The current behaviour of this function will dereference a null pointer if the serial# environment variable is unset. This was discovered on a board where U-Boot did not have access to the first 256MB of ram, resulting in a board crash. In the event that U-Boot has full access to memory, it will sti