Re: [PATCH v2] Makefile: fix generating environment file

2021-04-21 Thread Oleksandr Suvorov
On Wed, Apr 21, 2021 at 11:56 PM Rasmus Villemoes wrote: > > On 21/04/2021 17.21, Oleksandr Suvorov wrote: > > Hi Rasmus, > > > > On Wed, Apr 21, 2021 at 12:34 AM Rasmus Villemoes > > wrote: > >> > >> On 20/04/2021 23.10, Oleksandr Suvorov wrote: > >>> Hi Rasmus, > >>> > >>> Thanks for your feedb

Re: [PATCH v2] Makefile: fix generating environment file

2021-04-21 Thread Rasmus Villemoes
On 21/04/2021 17.21, Oleksandr Suvorov wrote: > Hi Rasmus, > > On Wed, Apr 21, 2021 at 12:34 AM Rasmus Villemoes > wrote: >> >> On 20/04/2021 23.10, Oleksandr Suvorov wrote: >>> Hi Rasmus, >>> >>> Thanks for your feedback! >>> Yes, I noted that there were no possible situations with the trailing

Re: [PATCH v2] Makefile: fix generating environment file

2021-04-21 Thread Oleksandr Suvorov
Hi Rasmus, On Wed, Apr 21, 2021 at 12:34 AM Rasmus Villemoes wrote: > > On 20/04/2021 23.10, Oleksandr Suvorov wrote: > > Hi Rasmus, > > > > Thanks for your feedback! > > Yes, I noted that there were no possible situations with the trailing > > code != 0x00, but simply removing the additional tra

Re: [PATCH v2] Makefile: fix generating environment file

2021-04-20 Thread Rasmus Villemoes
On 20/04/2021 23.10, Oleksandr Suvorov wrote: > Hi Rasmus, > > Thanks for your feedback! > Yes, I noted that there were no possible situations with the trailing > code != 0x00, but simply removing the additional trailing 0x00 > gives us an empty array default_environment[] for the empty defaultenv

Re: [PATCH v2] Makefile: fix generating environment file

2021-04-20 Thread Oleksandr Suvorov
Hi Rasmus, Thanks for your feedback! Yes, I noted that there were no possible situations with the trailing code != 0x00, but simply removing the additional trailing 0x00 gives us an empty array default_environment[] for the empty defaultenv file. I need to test whether this case is handled in u-bo

Re: [PATCH v2] Makefile: fix generating environment file

2021-04-20 Thread Rasmus Villemoes
On 20/04/2021 16.43, Oleksandr Suvorov wrote: > If the CONFIG_USE_DEFAULT_ENV_FILE=y and CONFIG_DEFAULT_ENV_FILE > points to the empty environment file, the auto-generated file has > the wrong syntax so it leads to the compilation failure: > Glad someone is using CONFIG_USE_DEFAULT_ENV_FILE :) And

[PATCH v2] Makefile: fix generating environment file

2021-04-20 Thread Oleksandr Suvorov
If the CONFIG_USE_DEFAULT_ENV_FILE=y and CONFIG_DEFAULT_ENV_FILE points to the empty environment file, the auto-generated file has the wrong syntax so it leads to the compilation failure: In file included from include/env_default.h:115, from env/common.c:29: include/generated/defa