Re: [PATCH v1 1/3] mach-sunxi: Add boot device detection for SUNIV

2022-02-10 Thread Andre Przywara
On Thu, 10 Feb 2022 14:51:11 -0500 Jesse Taube wrote: > On 2/10/22 14:38, Siarhei Siamashka wrote: > > On Thu, Feb 10, 2022 at 6:35 AM Jesse Taube wrote: > > [...] > >> + case SUNIV_BOOTED_FROM_NAND: > >> + case SUNIV_BOOTED_FROM_SPI: > >> + return BOOT_DEVICE_SPI;

Re: [PATCH v1 1/3] mach-sunxi: Add boot device detection for SUNIV

2022-02-10 Thread Andre Przywara
On Thu, 10 Feb 2022 14:20:26 -0500 Jesse Taube wrote: Hi, > On 2/10/22 05:57, Andre Przywara wrote: > > On Wed, 9 Feb 2022 23:34:36 -0500 > > Jesse Taube wrote: > > > > Hi Jesse, > > > > many thanks for sending this, much appreciated! > > > >> Use Samuel's suggestion of looking at the Boo

Re: [PATCH v1 1/3] mach-sunxi: Add boot device detection for SUNIV

2022-02-10 Thread Jesse Taube
On 2/10/22 14:38, Siarhei Siamashka wrote: On Thu, Feb 10, 2022 at 6:35 AM Jesse Taube wrote: [...] + case SUNIV_BOOTED_FROM_NAND: + case SUNIV_BOOTED_FROM_SPI: + return BOOT_DEVICE_SPI; Is it really okay to lump SPI and NAND together and return BOOT_DEVICE_SPI fo

Re: [PATCH v1 1/3] mach-sunxi: Add boot device detection for SUNIV

2022-02-10 Thread Jesse Taube
On 2/10/22 05:57, Andre Przywara wrote: On Wed, 9 Feb 2022 23:34:36 -0500 Jesse Taube wrote: Hi Jesse, many thanks for sending this, much appreciated! Use Samuel's suggestion of looking at the BootRom's stack to determine the boot device. Can you please elaborate here what's going on,

Re: [PATCH v1 1/3] mach-sunxi: Add boot device detection for SUNIV

2022-02-10 Thread Jesse Taube
On 2/10/22 05:57, Andre Przywara wrote: On Wed, 9 Feb 2022 23:34:36 -0500 Jesse Taube wrote: Hi Jesse, many thanks for sending this, much appreciated! Use Samuel's suggestion of looking at the BootRom's stack to determine the boot device. Can you please elaborate here what's going on,

Re: [PATCH v1 1/3] mach-sunxi: Add boot device detection for SUNIV

2022-02-10 Thread Andre Przywara
On Wed, 9 Feb 2022 23:34:36 -0500 Jesse Taube wrote: Hi Jesse, many thanks for sending this, much appreciated! > Use Samuel's suggestion of looking at the BootRom's stack > to determine the boot device. Can you please elaborate here what's going on, for future reference? Like: = I

[PATCH v1 1/3] mach-sunxi: Add boot device detection for SUNIV

2022-02-09 Thread Jesse Taube
Use Samuel's suggestion of looking at the BootRom's stack to determine the boot device. Signed-off-by: Jesse Taube Suggested-by: Samuel Holland --- arch/arm/include/asm/arch-sunxi/spl.h | 15 arch/arm/mach-sunxi/board.c | 50 --- 2 files changed, 38 in