Re: [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-04-07 Thread Simon Glass
Hi Andy, On Sun, 29 Mar 2020 at 15:00, Andy Shevchenko wrote: > > On Sun, Mar 29, 2020 at 5:13 AM Simon Glass wrote: > > On Thu, 5 Mar 2020 at 05:17, Andy Shevchenko > > wrote: > > > On Tue, Mar 03, 2020 at 07:47:56PM -0700, Simon Glass wrote: > > > > On Tue, 3 Mar 2020 at 02:23, Andy Shevchen

Re: [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-03-29 Thread Andy Shevchenko
On Sun, Mar 29, 2020 at 5:13 AM Simon Glass wrote: > On Thu, 5 Mar 2020 at 05:17, Andy Shevchenko > wrote: > > On Tue, Mar 03, 2020 at 07:47:56PM -0700, Simon Glass wrote: > > > On Tue, 3 Mar 2020 at 02:23, Andy Shevchenko > > > wrote: > > > > On Tue, Mar 3, 2020 at 1:36 AM Simon Glass wrote:

Re: [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-03-28 Thread Simon Glass
Hi Andy, On Thu, 5 Mar 2020 at 05:17, Andy Shevchenko wrote: > > On Tue, Mar 03, 2020 at 07:47:56PM -0700, Simon Glass wrote: > > On Tue, 3 Mar 2020 at 02:23, Andy Shevchenko > > wrote: > > > On Tue, Mar 3, 2020 at 1:36 AM Simon Glass wrote: > > > > On Mon, 2 Mar 2020 at 13:47, Andy Shevchenko

Re: [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-03-24 Thread Bin Meng
On Wed, Mar 25, 2020 at 2:48 PM Bin Meng wrote: > > On Thu, Feb 27, 2020 at 10:00 PM Andy Shevchenko > wrote: > > > > There is no need to have an assignment to NULL for XSDT pointer. > > Therefore, no need to assign it when rsdt_address is not set. > > Because of above changes we may decrease ind

Re: [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-03-24 Thread Bin Meng
On Thu, Feb 27, 2020 at 10:00 PM Andy Shevchenko wrote: > > There is no need to have an assignment to NULL for XSDT pointer. > Therefore, no need to assign it when rsdt_address is not set. > Because of above changes we may decrease indentation level as well. > > While here, drop unnecessary parent

Re: [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-03-05 Thread Andy Shevchenko
On Tue, Mar 03, 2020 at 07:47:56PM -0700, Simon Glass wrote: > On Tue, 3 Mar 2020 at 02:23, Andy Shevchenko > wrote: > > On Tue, Mar 3, 2020 at 1:36 AM Simon Glass wrote: > > > On Mon, 2 Mar 2020 at 13:47, Andy Shevchenko > > > wrote: > > > > On Mon, Mar 2, 2020 at 9:47 PM Simon Glass wrote:

Re: [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-03-03 Thread Simon Glass
Hi Andy, On Tue, 3 Mar 2020 at 02:23, Andy Shevchenko wrote: > > On Tue, Mar 3, 2020 at 1:36 AM Simon Glass wrote: > > On Mon, 2 Mar 2020 at 13:47, Andy Shevchenko > > wrote: > > > On Mon, Mar 2, 2020 at 9:47 PM Simon Glass wrote: > > > > On Fri, 28 Feb 2020 at 01:47, Andy Shevchenko > > > >

Re: Re: [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-03-03 Thread Andy Shevchenko
On Tue, Mar 3, 2020 at 12:00 PM Wolfgang Wallner wrote: ... > > Wait, this is not a *name*, this is ACPI _HID. ACPI _HID, of course, > > should be somewhere in board code. > > > > I was thinking myself about some U-Boot framework that actually takes > > ACPI _HID from the driver. So, when you de

Antwort: Re: [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-03-03 Thread Wolfgang Wallner
Hi Andy, -"U-Boot" schrieb: - > > [snip] > > > > > > P.S. Briefly looking at the last ~30 patches I can say that the idea > > > > > looks good, implementation needs more work. For example, there is > > > > > 'linux,name' property. Shouldn't be referred at all. Linux names and > > > > > o

Re: [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-03-03 Thread Andy Shevchenko
On Tue, Mar 3, 2020 at 1:36 AM Simon Glass wrote: > On Mon, 2 Mar 2020 at 13:47, Andy Shevchenko > wrote: > > On Mon, Mar 2, 2020 at 9:47 PM Simon Glass wrote: > > > On Fri, 28 Feb 2020 at 01:47, Andy Shevchenko > > > wrote: > > > > On Fri, Feb 28, 2020 at 1:41 AM Simon Glass wrote: > > > >

Re: [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-03-02 Thread Bin Meng
On Tue, Mar 3, 2020 at 7:36 AM Simon Glass wrote: > > Hi Andy, > > On Mon, 2 Mar 2020 at 13:47, Andy Shevchenko > wrote: > > > > On Mon, Mar 2, 2020 at 9:47 PM Simon Glass wrote: > > > On Fri, 28 Feb 2020 at 01:47, Andy Shevchenko > > > wrote: > > > > On Fri, Feb 28, 2020 at 1:41 AM Simon Gla

Re: [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-03-02 Thread Simon Glass
Hi Andy, On Mon, 2 Mar 2020 at 13:47, Andy Shevchenko wrote: > > On Mon, Mar 2, 2020 at 9:47 PM Simon Glass wrote: > > On Fri, 28 Feb 2020 at 01:47, Andy Shevchenko > > wrote: > > > On Fri, Feb 28, 2020 at 1:41 AM Simon Glass wrote: > > > > On Thu, 27 Feb 2020 at 06:00, Andy Shevchenko > > >

Re: [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-03-02 Thread Andy Shevchenko
On Mon, Mar 2, 2020 at 9:47 PM Simon Glass wrote: > On Fri, 28 Feb 2020 at 01:47, Andy Shevchenko > wrote: > > On Fri, Feb 28, 2020 at 1:41 AM Simon Glass wrote: > > > On Thu, 27 Feb 2020 at 06:00, Andy Shevchenko > > > wrote: > > > > > Could you take a look at the ACPI series? > > > > > > It

Re: [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-03-02 Thread Simon Glass
Hi Andy, On Fri, 28 Feb 2020 at 01:47, Andy Shevchenko wrote: > > On Fri, Feb 28, 2020 at 1:41 AM Simon Glass wrote: > > On Thu, 27 Feb 2020 at 06:00, Andy Shevchenko > > wrote: > > > Could you take a look at the ACPI series? > > > > It was sent out about a month ago and has a refactor to this

Re: [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-02-28 Thread Andy Shevchenko
On Fri, Feb 28, 2020 at 1:41 AM Simon Glass wrote: > On Thu, 27 Feb 2020 at 06:00, Andy Shevchenko > wrote: > Could you take a look at the ACPI series? > > It was sent out about a month ago and has a refactor to this function. > > u-boot-dm/coral-working There are tons of changes. Care to point

Re: [PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-02-27 Thread Simon Glass
Hi Andy, On Thu, 27 Feb 2020 at 06:00, Andy Shevchenko wrote: > > There is no need to have an assignment to NULL for XSDT pointer. > Therefore, no need to assign it when rsdt_address is not set. > Because of above changes we may decrease indentation level as well. > > While here, drop unnecessary

[PATCH v1] x86: acpi: Refactor XSDT handling in acpi_add_table()

2020-02-27 Thread Andy Shevchenko
There is no need to have an assignment to NULL for XSDT pointer. Therefore, no need to assign it when rsdt_address is not set. Because of above changes we may decrease indentation level as well. While here, drop unnecessary parentheses. Signed-off-by: Andy Shevchenko --- arch/x86/lib/acpi_table