Re: [PATCH u-boot v3.1 01/39] regmap: fix a serious pointer casting bug

2021-03-16 Thread Marek Behun
On Tue, 16 Mar 2021 22:04:17 +0530 Pratyush Yadav wrote: > > + switch (map->width) { > > + case REGMAP_SIZE_8: > > + *valp = u.v8; > > + break; > > + case REGMAP_SIZE_16: > > + *valp = u.v16; > > + break; > > + case REGMAP_SIZE_32: > > + *

Re: [PATCH u-boot v3.1 01/39] regmap: fix a serious pointer casting bug

2021-03-16 Thread Pratyush Yadav
Hi Marek, On 16/03/21 04:07PM, Marek BehĂșn wrote: > There is a serious bug in regmap_read() and regmap_write() functions > where an uint pointer is cast to (void *) which is then cast to (u8 *), > (u16 *), (u32 *) or (u64 *), depending on register width of the map. > > For example given a regmap

[PATCH u-boot v3.1 01/39] regmap: fix a serious pointer casting bug

2021-03-16 Thread Marek BehĂșn
There is a serious bug in regmap_read() and regmap_write() functions where an uint pointer is cast to (void *) which is then cast to (u8 *), (u16 *), (u32 *) or (u64 *), depending on register width of the map. For example given a regmap with 16-bit register width the code int val = 0x12340