Re: [PATCH u-boot] dm: pci: Fix handling of errors when scanning device

2021-09-26 Thread Simon Glass
On 07.09.21 18:07, Marek Behún wrote: > From: Pali Rohár > > Some PCIe controller's read_config() method support indicating error > directly via return value, but some cannot distinguish all-ones (or > all-zeros) read response from an error. > > The current code in pci_bind_bus_devices() interpret

Re: [PATCH u-boot] dm: pci: Fix handling of errors when scanning device

2021-09-10 Thread Stefan Roese
On 07.09.21 18:07, Marek Behún wrote: From: Pali Rohár Some PCIe controller's read_config() method support indicating error directly via return value, but some cannot distinguish all-ones (or all-zeros) read response from an error. The current code in pci_bind_bus_devices() interprets all-ones

Re: [PATCH u-boot] dm: pci: Fix handling of errors when scanning device

2021-09-08 Thread Pali Rohár
On Wednesday 08 September 2021 20:57:06 Bin Meng wrote: > On Wed, Sep 8, 2021 at 8:02 PM Marek Behún wrote: > > > > On Wed, 8 Sep 2021 09:06:28 +0800 > > Bin Meng wrote: > > > > > On Wed, Sep 8, 2021 at 12:07 AM Marek Behún > > > wrote: > > > > > > > > From: Pali Rohár > > > > > > > > Some PCIe

Re: [PATCH u-boot] dm: pci: Fix handling of errors when scanning device

2021-09-08 Thread Bin Meng
On Wed, Sep 8, 2021 at 8:02 PM Marek Behún wrote: > > On Wed, 8 Sep 2021 09:06:28 +0800 > Bin Meng wrote: > > > On Wed, Sep 8, 2021 at 12:07 AM Marek Behún > > wrote: > > > > > > From: Pali Rohár > > > > > > Some PCIe controller's read_config() method support indicating error > > > directly via

Re: [PATCH u-boot] dm: pci: Fix handling of errors when scanning device

2021-09-08 Thread Marek Behún
On Wed, 8 Sep 2021 09:06:28 +0800 Bin Meng wrote: > On Wed, Sep 8, 2021 at 12:07 AM Marek Behún > wrote: > > > > From: Pali Rohár > > > > Some PCIe controller's read_config() method support indicating error > > directly via return value, but some cannot distinguish all-ones (or > > all-zeros) r

Re: [PATCH u-boot] dm: pci: Fix handling of errors when scanning device

2021-09-07 Thread Bin Meng
On Wed, Sep 8, 2021 at 12:07 AM Marek Behún wrote: > > From: Pali Rohár > > Some PCIe controller's read_config() method support indicating error > directly via return value, but some cannot distinguish all-ones (or > all-zeros) read response from an error. > > The current code in pci_bind_bus_dev

[PATCH u-boot] dm: pci: Fix handling of errors when scanning device

2021-09-07 Thread Marek Behún
From: Pali Rohár Some PCIe controller's read_config() method support indicating error directly via return value, but some cannot distinguish all-ones (or all-zeros) read response from an error. The current code in pci_bind_bus_devices() interprets all-ones / all-zeros in PCI_VENDOR_ID register a