Re: [PATCH resend 0/2] gpio: mpc8xxx: honour shadow register when writing gpdat

2020-03-31 Thread Rasmus Villemoes
On 23/03/2020 21.45, Tom Rini wrote: > On Mon, Mar 23, 2020 at 01:13:01AM +0100, Rasmus Villemoes wrote: >> On 03/03/2020 13.19, Rasmus Villemoes wrote: >>> On 28/01/2020 13.04, Rasmus Villemoes wrote: [resending with Mario's correct address, sorry for the double post] The driver cor

Re: [PATCH resend 0/2] gpio: mpc8xxx: honour shadow register when writing gpdat

2020-03-23 Thread Tom Rini
On Mon, Mar 23, 2020 at 01:13:01AM +0100, Rasmus Villemoes wrote: > On 03/03/2020 13.19, Rasmus Villemoes wrote: > > On 28/01/2020 13.04, Rasmus Villemoes wrote: > >> [resending with Mario's correct address, sorry for the double post] > >> > >> The driver correctly uses the shadow register when ask

Re: [PATCH resend 0/2] gpio: mpc8xxx: honour shadow register when writing gpdat

2020-03-22 Thread Rasmus Villemoes
On 03/03/2020 13.19, Rasmus Villemoes wrote: > On 28/01/2020 13.04, Rasmus Villemoes wrote: >> [resending with Mario's correct address, sorry for the double post] >> >> The driver correctly uses the shadow register when asked for the >> current value of an output gpio. Unfortunately, it does RMW on

Re: [PATCH resend 0/2] gpio: mpc8xxx: honour shadow register when writing gpdat

2020-03-03 Thread Rasmus Villemoes
On 28/01/2020 13.04, Rasmus Villemoes wrote: > [resending with Mario's correct address, sorry for the double post] > > The driver correctly uses the shadow register when asked for the > current value of an output gpio. Unfortunately, it does RMW on the > gpdat register both when setting a gpio as

Re: [PATCH resend 0/2] gpio: mpc8xxx: honour shadow register when writing gpdat

2020-02-11 Thread Rasmus Villemoes
On 28/01/2020 13.04, Rasmus Villemoes wrote: > Rasmus Villemoes (2): > gpio: mpc8xxx: don't modify gpdat when setting gpio as input > gpio: mpc8xxx: don't do RMW on gpdat register when setting value > > drivers/gpio/mpc8xxx_gpio.c | 41 ++--- > 1 file changed,

[PATCH resend 0/2] gpio: mpc8xxx: honour shadow register when writing gpdat

2020-01-28 Thread Rasmus Villemoes
[resending with Mario's correct address, sorry for the double post] The driver correctly uses the shadow register when asked for the current value of an output gpio. Unfortunately, it does RMW on the gpdat register both when setting a gpio as input and output. These two patches fix that. Aside: A