Re: [PATCH next v2 4/4] rockchip: rk3399: move sysreset-gpio logic to TPL

2024-11-12 Thread Dragan Simic
Hello Kever, On 2024-11-08 01:50, Kever Yang wrote: On 2024/11/7 20:27, Paul Kocialkowski wrote: Le Thu 07 Nov 24, 12:04, Quentin Schulz a écrit : On 11/7/24 8:14 AM, Kever Yang wrote: Yes, this movement is reasonable and needed for this workaround, although still not understand why puma boa

Re: [PATCH next v2 4/4] rockchip: rk3399: move sysreset-gpio logic to TPL

2024-11-07 Thread Kever Yang
On 2024/11/6 19:29, Quentin Schulz wrote: From: Quentin Schulz If TPL_GPIO and TPL_PINCTRL_ROCKCHIP are enabled and a sysreset-gpio is provided in the TPL Device Tree, this will trigger a system reset similar to what's currently been done in SPL whenever the RK3399 "warm" boots. Because there

Re: [PATCH next v2 4/4] rockchip: rk3399: move sysreset-gpio logic to TPL

2024-11-07 Thread Kever Yang
Hi Paul, On 2024/11/7 20:27, Paul Kocialkowski wrote: Hi, Le Thu 07 Nov 24, 12:04, Quentin Schulz a écrit : On 11/7/24 8:14 AM, Kever Yang wrote: Yes, this movement is reasonable and needed for this workaround, although still not understand why puma board need this. Me neither, this predate

Re: [PATCH next v2 4/4] rockchip: rk3399: move sysreset-gpio logic to TPL

2024-11-07 Thread Paul Kocialkowski
Hi, Le Wed 06 Nov 24, 12:29, Quentin Schulz a écrit : > From: Quentin Schulz > > If TPL_GPIO and TPL_PINCTRL_ROCKCHIP are enabled and a sysreset-gpio is > provided in the TPL Device Tree, this will trigger a system reset > similar to what's currently been done in SPL whenever the RK3399 "warm" >

Re: [PATCH next v2 4/4] rockchip: rk3399: move sysreset-gpio logic to TPL

2024-11-07 Thread Paul Kocialkowski
Hi, Le Thu 07 Nov 24, 12:04, Quentin Schulz a écrit : > On 11/7/24 8:14 AM, Kever Yang wrote: > > Yes, this movement is reasonable and needed for this workaround, > > although still not > > > > understand why puma board need this. > > Me neither, this predates me joining the company, c.f.: > htt

Re: [PATCH next v2 4/4] rockchip: rk3399: move sysreset-gpio logic to TPL

2024-11-07 Thread Quentin Schulz
Hi Kever, On 11/7/24 8:14 AM, Kever Yang wrote: Hi Quentin, On 2024/11/6 19:29, Quentin Schulz wrote: From: Quentin Schulz If TPL_GPIO and TPL_PINCTRL_ROCKCHIP are enabled and a sysreset-gpio is provided in the TPL Device Tree, this will trigger a system reset similar to what's currently bee

Re: [PATCH next v2 4/4] rockchip: rk3399: move sysreset-gpio logic to TPL

2024-11-06 Thread Kever Yang
Hi Quentin, On 2024/11/6 19:29, Quentin Schulz wrote: From: Quentin Schulz If TPL_GPIO and TPL_PINCTRL_ROCKCHIP are enabled and a sysreset-gpio is provided in the TPL Device Tree, this will trigger a system reset similar to what's currently been done in SPL whenever the RK3399 "warm" boots. Be

[PATCH next v2 4/4] rockchip: rk3399: move sysreset-gpio logic to TPL

2024-11-06 Thread Quentin Schulz
From: Quentin Schulz If TPL_GPIO and TPL_PINCTRL_ROCKCHIP are enabled and a sysreset-gpio is provided in the TPL Device Tree, this will trigger a system reset similar to what's currently been done in SPL whenever the RK3399 "warm" boots. Because there's currently only one user of sysreset-gpio lo