Re: [PATCH RFC v2 3/5] lib: Add support for ECDSA image signing

2021-01-07 Thread Alex G.
On 1/7/21 11:25 AM, Tom Rini wrote: On Thu, Jan 07, 2021 at 10:27:50AM -0600, Alex G. wrote: On 1/7/21 6:35 AM, Simon Glass wrote: Hi Alexandru, Hi Simon, (pun alert!) A lot of your comments have to do with comments. I use comments as a tool to add something of value to code. When the cod

Re: [PATCH RFC v2 3/5] lib: Add support for ECDSA image signing

2021-01-07 Thread Alex G.
On 1/7/21 11:29 AM, Simon Glass wrote: Hi Alex, On Thu, 7 Jan 2021 at 09:27, Alex G. wrote: On 1/7/21 6:35 AM, Simon Glass wrote: Hi Alexandru, Hi Simon, (pun alert!) A lot of your comments have to do with comments. I use comments as a tool to add something of value to code. When the code

Re: [PATCH RFC v2 3/5] lib: Add support for ECDSA image signing

2021-01-07 Thread Simon Glass
Hi Alex, On Thu, 7 Jan 2021 at 09:27, Alex G. wrote: > > On 1/7/21 6:35 AM, Simon Glass wrote: > > Hi Alexandru, > > Hi Simon, > > (pun alert!) A lot of your comments have to do with comments. I use > comments as a tool to add something of value to code. When the code is > self-documenting, comme

Re: [PATCH RFC v2 3/5] lib: Add support for ECDSA image signing

2021-01-07 Thread Tom Rini
On Thu, Jan 07, 2021 at 10:27:50AM -0600, Alex G. wrote: > On 1/7/21 6:35 AM, Simon Glass wrote: > > Hi Alexandru, > > Hi Simon, > > (pun alert!) A lot of your comments have to do with comments. I use comments > as a tool to add something of value to code. When the code is > self-documenting, com

Re: [PATCH RFC v2 3/5] lib: Add support for ECDSA image signing

2021-01-07 Thread Alex G.
On 1/7/21 6:35 AM, Simon Glass wrote: Hi Alexandru, Hi Simon, (pun alert!) A lot of your comments have to do with comments. I use comments as a tool to add something of value to code. When the code is self-documenting, comments don't help much. See kernel coding style chapter 8. What comme

Re: [PATCH RFC v2 3/5] lib: Add support for ECDSA image signing

2021-01-07 Thread Simon Glass
Hi Alexandru, On Wed, 30 Dec 2020 at 14:00, Alexandru Gagniuc wrote: > > mkimage supports rsa2048, and rsa4096 signatures. With newer silicon > now supporting hardware-accelerated ECDSA, it makes sense to expand > signing support to elliptic curves. > > Implement host-side ECDSA signing and verif

[PATCH RFC v2 3/5] lib: Add support for ECDSA image signing

2020-12-30 Thread Alexandru Gagniuc
mkimage supports rsa2048, and rsa4096 signatures. With newer silicon now supporting hardware-accelerated ECDSA, it makes sense to expand signing support to elliptic curves. Implement host-side ECDSA signing and verification with libcrypto. Device-side implementation of signature verification is be