Re: [PATCH 7/8] usb: ci_udc: Convert driver to DM_USB_GADGET

2020-10-27 Thread Wolfgang Denk
Dear Peng Fan, In message you wrote: > > > > > > > > +static const struct udevice_id ci_udc_otg_ids[] = { > > > > > > > + { .compatible = "fsl,imx27-usb-gadget" }, > > > > > > > + { } > > > > > > > +}; ... > > Maybe I'm missing something, but I cannot find imx27-usb-gadget being used > > anywhe

RE: [PATCH 7/8] usb: ci_udc: Convert driver to DM_USB_GADGET

2020-10-27 Thread Peng Fan
> Subject: Re: [PATCH 7/8] usb: ci_udc: Convert driver to DM_USB_GADGET > > Dear Peng Fan, > > In message > eurprd04.prod.outlook.com> you wrote: > > > > > > > > > > +static const struct udevice_id ci_udc_otg_ids[] = { &g

Re: [PATCH 7/8] usb: ci_udc: Convert driver to DM_USB_GADGET

2020-10-27 Thread Wolfgang Denk
Dear Peng Fan, In message you wrote: > > > > > > > > +static const struct udevice_id ci_udc_otg_ids[] = { > > > > > + { .compatible = "fsl,imx27-usb-gadget" }, > > > > > + { } > > > > > +}; > > > > > > > > What is imx27-usb-gadget ? > > > > > > This U-Boot specific compatible string. I

RE: [PATCH 7/8] usb: ci_udc: Convert driver to DM_USB_GADGET

2020-10-27 Thread Peng Fan
> Subject: Re: [PATCH 7/8] usb: ci_udc: Convert driver to DM_USB_GADGET > > Dear Peng Fan, > > In message > eurprd04.prod.outlook.com> you wrote: > > > > > > +static const struct udevice_id ci_udc_otg_ids[] = { > > >

Re: [PATCH 7/8] usb: ci_udc: Convert driver to DM_USB_GADGET

2020-10-27 Thread Wolfgang Denk
Dear Peng Fan, In message you wrote: > > > > +static const struct udevice_id ci_udc_otg_ids[] = { > > > + { .compatible = "fsl,imx27-usb-gadget" }, > > > + { } > > > +}; > > > > What is imx27-usb-gadget ? > > This U-Boot specific compatible string. I have no better idea > what we need use her

RE: [PATCH 7/8] usb: ci_udc: Convert driver to DM_USB_GADGET

2020-10-27 Thread Peng Fan
> Subject: Re: [PATCH 7/8] usb: ci_udc: Convert driver to DM_USB_GADGET > > Dear Peng Fan, > > In message <20201012062354.3743-8-peng@nxp.com> you wrote: > > > > Convert the ci_udc driver to driver model by using the uclass > > UCLASS_USB_GADGET_GENER

Re: [PATCH 7/8] usb: ci_udc: Convert driver to DM_USB_GADGET

2020-10-27 Thread Wolfgang Denk
Dear Peng Fan, In message <20201012062354.3743-8-peng@nxp.com> you wrote: > > Convert the ci_udc driver to driver model by using the uclass > UCLASS_USB_GADGET_GENERIC. The clk and power of USB controller and USB > PHY both are initialized by parsing the device tree nodes. ... > +static const

[PATCH 7/8] usb: ci_udc: Convert driver to DM_USB_GADGET

2020-10-11 Thread Peng Fan
From: Sherry Sun Convert the ci_udc driver to driver model by using the uclass UCLASS_USB_GADGET_GENERIC. The clk and power of USB controller and USB PHY both are initialized by parsing the device tree nodes. If CONFIG_DM_USB_GADGET is defined, we use the ci_udc driver in DM way, if it does not