Re: [PATCH 6/8] ARM: imx8m: Fix reset in SPL on NXP iMX8MP EVK

2020-05-05 Thread Marek Vasut
On 5/5/20 10:54 AM, Harald Seiler wrote: > Hello Fabio, Hi > On Mon, 2020-05-04 at 12:28 -0300, Fabio Estevam wrote: >> On Mon, May 4, 2020 at 12:21 PM Harald Seiler wrote: >> >>> With or without the revert? >> >> When I change the defconfig like: >> >> --- a/configs/imx8mp_evk_defconfig >> +++

Re: [PATCH 6/8] ARM: imx8m: Fix reset in SPL on NXP iMX8MP EVK

2020-05-05 Thread Harald Seiler
Hello Fabio, On Mon, 2020-05-04 at 12:28 -0300, Fabio Estevam wrote: > On Mon, May 4, 2020 at 12:21 PM Harald Seiler wrote: > > > With or without the revert? > > When I change the defconfig like: > > --- a/configs/imx8mp_evk_defconfig > +++ b/configs/imx8mp_evk_defconfig > @@ -57,7 +57,9 @@ CO

Re: [PATCH 6/8] ARM: imx8m: Fix reset in SPL on NXP iMX8MP EVK

2020-05-04 Thread Fabio Estevam
On Mon, May 4, 2020 at 12:21 PM Harald Seiler wrote: > With or without the revert? When I change the defconfig like: --- a/configs/imx8mp_evk_defconfig +++ b/configs/imx8mp_evk_defconfig @@ -57,7 +57,9 @@ CONFIG_ENV_IS_IN_MMC=y CONFIG_SYS_RELOC_GD_ENV_ADDR=y CONFIG_ENV_VARS_UBOOT_RUNTIME_CONF

Re: [PATCH 6/8] ARM: imx8m: Fix reset in SPL on NXP iMX8MP EVK

2020-05-04 Thread Harald Seiler
On Mon, 2020-05-04 at 12:18 -0300, Fabio Estevam wrote: > On Mon, May 4, 2020 at 12:05 PM Harald Seiler wrote: > > > "Failed to find clock node. Check device tree" comes from spl_board_init() > > in board/freescale/imx8mp_evk/spl.c; line 56: > > > > ret = uclass_get_device_by_name(UCLASS

Re: [PATCH 6/8] ARM: imx8m: Fix reset in SPL on NXP iMX8MP EVK

2020-05-04 Thread Fabio Estevam
On Mon, May 4, 2020 at 12:05 PM Harald Seiler wrote: > "Failed to find clock node. Check device tree" comes from spl_board_init() > in board/freescale/imx8mp_evk/spl.c; line 56: > > ret = uclass_get_device_by_name(UCLASS_CLK, > "clock-controller@303

Re: [PATCH 6/8] ARM: imx8m: Fix reset in SPL on NXP iMX8MP EVK

2020-05-04 Thread Harald Seiler
Hello, On Mon, 2020-05-04 at 16:32 +0200, Marek Vasut wrote: > On 5/4/20 4:27 PM, Fabio Estevam wrote: > > Hi, > > > > On Wed, Apr 29, 2020 at 10:05 AM Harald Seiler wrote: > > > From: Marek Vasut > > > > > > Board files should not re-implement do_reset() to work around this > > > function not

Re: [PATCH 6/8] ARM: imx8m: Fix reset in SPL on NXP iMX8MP EVK

2020-05-04 Thread Marek Vasut
On 5/4/20 4:27 PM, Fabio Estevam wrote: > Hi, > > On Wed, Apr 29, 2020 at 10:05 AM Harald Seiler wrote: >> >> From: Marek Vasut >> >> Board files should not re-implement do_reset() to work around this >> function not being defined in for specific configurations. Rather, >> the fix is to compile

Re: [PATCH 6/8] ARM: imx8m: Fix reset in SPL on NXP iMX8MP EVK

2020-05-04 Thread Fabio Estevam
Hi, On Wed, Apr 29, 2020 at 10:05 AM Harald Seiler wrote: > > From: Marek Vasut > > Board files should not re-implement do_reset() to work around this > function not being defined in for specific configurations. Rather, > the fix is to compile in drivers which implement this properly. > This pat

[PATCH 6/8] ARM: imx8m: Fix reset in SPL on NXP iMX8MP EVK

2020-05-01 Thread sbabic
> From: Marek Vasut > Board files should not re-implement do_reset() to work around this > function not being defined in for specific configurations. Rather, > the fix is to compile in drivers which implement this properly. > This patch enables sysreset and watchdog drivers in SPL and ties > them

[PATCH 6/8] ARM: imx8m: Fix reset in SPL on NXP iMX8MP EVK

2020-04-29 Thread Harald Seiler
From: Marek Vasut Board files should not re-implement do_reset() to work around this function not being defined in for specific configurations. Rather, the fix is to compile in drivers which implement this properly. This patch enables sysreset and watchdog drivers in SPL and ties them together to