Re: [PATCH 5/8] image: Adjust the workings of fit_check_format()

2021-02-17 Thread Jesper Schmitz Mouridsen
On 17.02.2021 14.43, Tom Rini wrote: On Wed, Feb 17, 2021 at 02:30:56PM +0100, Jesper Schmitz Mouridsen wrote: Hi Can you avoid the use of ENODATA since it is not defined in FreeBSD's errno.h? I like that FreeBSD has EDOOFUS, but I don't see an obvious replacement for ENODATA, can you sugges

Re: [PATCH 5/8] image: Adjust the workings of fit_check_format()

2021-02-17 Thread Jesper Schmitz Mouridsen
Hi Can you avoid the use of ENODATA since it is not defined in FreeBSD's errno.h? Regards Jesper Schmitz Mouridsen On 16.02.2021 01.08, Simon Glass wrote: At present this function does not accept a size for the FIT. This means that it must be read from the FIT itself, introducing potential

Re: [PATCH 5/8] image: Adjust the workings of fit_check_format()

2021-02-17 Thread Tom Rini
On Wed, Feb 17, 2021 at 02:30:56PM +0100, Jesper Schmitz Mouridsen wrote: > Hi > > Can you avoid the use of ENODATA since it is not defined in FreeBSD's > > errno.h? I like that FreeBSD has EDOOFUS, but I don't see an obvious replacement for ENODATA, can you suggest something please? Thanks!

Re: [PATCH 5/8] image: Adjust the workings of fit_check_format()

2021-02-15 Thread Tom Rini
On Mon, Feb 15, 2021 at 05:08:09PM -0700, Simon Glass wrote: > At present this function does not accept a size for the FIT. This means > that it must be read from the FIT itself, introducing potential security > risk. Update the function to include a size parameter, which can be > invalid, in whic

[PATCH 5/8] image: Adjust the workings of fit_check_format()

2021-02-15 Thread Simon Glass
At present this function does not accept a size for the FIT. This means that it must be read from the FIT itself, introducing potential security risk. Update the function to include a size parameter, which can be invalid, in which case fit_check_format() calculates it. For now no callers pass the