Re: [PATCH 5/7] riscv: Add fence to available_harts_lock

2020-09-11 Thread Bin Meng
On Tue, Sep 8, 2020 at 2:17 AM Sean Anderson wrote: > > Without these fences, it is perfectly valid for an out-of-order core to > re-order memory accesses to outside of the available_harts_lock critical > section. The commit message should be reworded, because current codes do nothing wrong as "f

Re: [PATCH 5/7] riscv: Add fence to available_harts_lock

2020-09-11 Thread Sean Anderson
On 9/9/20 11:26 PM, Rick Chen wrote: > Hi Sean > >> Without these fences, it is perfectly valid for an out-of-order core to >> re-order memory accesses to outside of the available_harts_lock critical >> section. >> >> Signed-off-by: Sean Anderson >> --- >> >> arch/riscv/cpu/start.S | 6 +++--- >>

Re: [PATCH 5/7] riscv: Add fence to available_harts_lock

2020-09-09 Thread Rick Chen
Hi Sean > Without these fences, it is perfectly valid for an out-of-order core to > re-order memory accesses to outside of the available_harts_lock critical > section. > > Signed-off-by: Sean Anderson > --- > > arch/riscv/cpu/start.S | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH 5/7] riscv: Add fence to available_harts_lock

2020-09-07 Thread Sean Anderson
Without these fences, it is perfectly valid for an out-of-order core to re-order memory accesses to outside of the available_harts_lock critical section. Signed-off-by: Sean Anderson --- arch/riscv/cpu/start.S | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/riscv/