Re: [PATCH 5/6] net: tftp: use IS_ENABLED(CONFIG_NET_TFTP_VARS) instead of #if

On Fri, Oct 14, 2022 at 07:43:41PM +0200, Rasmus Villemoes wrote: > Nothing inside this block depends on NET_TFTP_VARS to be set to parse > correctly. Switch to C if() in preparation for adding code before > this (to avoid a declaration-after-statement warning). > > Signed-off-by: Rasmus Villemoe

Re: [PATCH 5/6] net: tftp: use IS_ENABLED(CONFIG_NET_TFTP_VARS) instead of #if

On 16/10/2022 20.28, Ramon Fried wrote: > On Fri, Oct 14, 2022 at 8:44 PM Rasmus Villemoes > wrote: >> >> Nothing inside this block depends on NET_TFTP_VARS to be set to parse >> correctly. Switch to C if() in preparation for adding code before >> this (to avoid a declaration-after-statement warni

Re: [PATCH 5/6] net: tftp: use IS_ENABLED(CONFIG_NET_TFTP_VARS) instead of #if

On Fri, Oct 14, 2022 at 8:44 PM Rasmus Villemoes wrote: > > Nothing inside this block depends on NET_TFTP_VARS to be set to parse > correctly. Switch to C if() in preparation for adding code before > this (to avoid a declaration-after-statement warning). What's the motivation here ? The #ifdef is

[PATCH 5/6] net: tftp: use IS_ENABLED(CONFIG_NET_TFTP_VARS) instead of #if

Nothing inside this block depends on NET_TFTP_VARS to be set to parse correctly. Switch to C if() in preparation for adding code before this (to avoid a declaration-after-statement warning). Signed-off-by: Rasmus Villemoes --- net/tftp.c | 56 +++--