Re: [PATCH 5/6] net: add MV88E61xx DSA driver

2022-04-14 Thread Tim Harvey
On Tue, Apr 12, 2022 at 7:13 AM Vladimir Oltean wrote: > > On Tue, Mar 29, 2022 at 03:52:39PM -0700, Tim Harvey wrote: > > Add a DSA driver for the MV88E61xx compatible GbE Ethernet switches. > > > > Signed-off-by: Tim Harvey > > --- > > drivers/net/Kconfig | 7 + > > drivers/net/Makefile

Re: [PATCH 5/6] net: add MV88E61xx DSA driver

2022-04-12 Thread Vladimir Oltean
On Tue, Mar 29, 2022 at 03:52:39PM -0700, Tim Harvey wrote: > Add a DSA driver for the MV88E61xx compatible GbE Ethernet switches. > > Signed-off-by: Tim Harvey > --- > drivers/net/Kconfig | 7 + > drivers/net/Makefile| 1 + > drivers/net/mv88e61xx.c | 982 +++

Re: [PATCH 5/6] net: add MV88E61xx DSA driver

2022-04-07 Thread Marek Behún
On Thu, 7 Apr 2022 16:03:12 -0700 Tim Harvey wrote: > Is there a move to try and move all network drivers to DM_MDIO > eliminating the need for struct mii_dev* within those drivers? Yes. Marek

Re: [PATCH 5/6] net: add MV88E61xx DSA driver

2022-04-07 Thread Tim Harvey
On Thu, Apr 7, 2022 at 2:31 PM Vladimir Oltean wrote: > > On Thu, Apr 07, 2022 at 01:33:58PM -0700, Tim Harvey wrote: > > I guess I'll have to invest in tagging packets if you won't accept the > > simplistic approach of not having to tag frames knowing that only one > > port is active at a time. >

Re: [PATCH 5/6] net: add MV88E61xx DSA driver

2022-04-07 Thread Vladimir Oltean
On Thu, Apr 07, 2022 at 01:33:58PM -0700, Tim Harvey wrote: > I guess I'll have to invest in tagging packets if you won't accept the > simplistic approach of not having to tag frames knowing that only one > port is active at a time. I genuinely don't know where you got the impression from that I d

Re: [PATCH 5/6] net: add MV88E61xx DSA driver

2022-04-07 Thread Tim Harvey
On Sat, Apr 2, 2022 at 4:17 PM Vladimir Oltean wrote: > > On Fri, Apr 01, 2022 at 01:24:48PM -0700, Tim Harvey wrote: > > > > > Why is mv88e61xx_dsa_xmit() no-op? > > > > > > > > For DSA dsa-uclass calls the switch master eth device send function > > > > after calling the dsa_ops->xmit function so

Re: [PATCH 5/6] net: add MV88E61xx DSA driver

2022-04-02 Thread Vladimir Oltean
On Fri, Apr 01, 2022 at 01:24:48PM -0700, Tim Harvey wrote: > > > > Why is mv88e61xx_dsa_xmit() no-op? > > > > > > For DSA dsa-uclass calls the switch master eth device send function > > > after calling the dsa_ops->xmit function so that a dsa driver can add > > > any header/footer if needed. The f

Re: [PATCH 5/6] net: add MV88E61xx DSA driver

2022-04-01 Thread Tim Harvey
On Thu, Mar 31, 2022 at 3:30 AM Marek Behún wrote: > > On Wed, 30 Mar 2022 08:46:06 -0700 > Tim Harvey wrote: > > > On Tue, Mar 29, 2022 at 4:22 PM Marek Behún wrote: > > > > > > On Tue, 29 Mar 2022 15:52:39 -0700 > > > Tim Harvey wrote: > > > > > > > Add a DSA driver for the MV88E61xx compatib

Re: [PATCH 5/6] net: add MV88E61xx DSA driver

2022-03-31 Thread Marek Behún
On Wed, 30 Mar 2022 08:46:06 -0700 Tim Harvey wrote: > On Tue, Mar 29, 2022 at 4:22 PM Marek Behún wrote: > > > > On Tue, 29 Mar 2022 15:52:39 -0700 > > Tim Harvey wrote: > > > > > Add a DSA driver for the MV88E61xx compatible GbE Ethernet switches. > > > > > > Signed-off-by: Tim Harvey >

Re: [PATCH 5/6] net: add MV88E61xx DSA driver

2022-03-30 Thread Tim Harvey
On Tue, Mar 29, 2022 at 4:22 PM Marek Behún wrote: > > On Tue, 29 Mar 2022 15:52:39 -0700 > Tim Harvey wrote: > > > Add a DSA driver for the MV88E61xx compatible GbE Ethernet switches. > > > > Signed-off-by: Tim Harvey > Marek, Thanks for looking at this. > Is this final version that should b

Re: [PATCH 5/6] net: add MV88E61xx DSA driver

2022-03-29 Thread Marek Behún
On Tue, 29 Mar 2022 15:52:39 -0700 Tim Harvey wrote: > Add a DSA driver for the MV88E61xx compatible GbE Ethernet switches. > > Signed-off-by: Tim Harvey Is this final version that should be accepted? The drivers seems to support not only 61xx, but 6xxx (6096, 6250, 6352, ...). Also there ar

[PATCH 5/6] net: add MV88E61xx DSA driver

2022-03-29 Thread Tim Harvey
Add a DSA driver for the MV88E61xx compatible GbE Ethernet switches. Signed-off-by: Tim Harvey --- drivers/net/Kconfig | 7 + drivers/net/Makefile| 1 + drivers/net/mv88e61xx.c | 982 3 files changed, 990 insertions(+) create mode 100644 driv