Re: [PATCH 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-14 Thread André Przywara
On 14/12/2020 15:02, Amit Tomar wrote: > Hi, > > You could pass a pointer to owl_mmc_priv here, which can hold both those > > values. See below for more more on this. > > Did you mean for argument 3rd and 4th but then in that case how one > could have differentiated > between source and dest

Re: [PATCH 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-14 Thread Amit Tomar
Hi, You could pass a pointer to owl_mmc_priv here, which can hold both those > values. See below for more more on this. > > Did you mean for argument 3rd and 4th but then in that case how one could have differentiated between source and destination. for instance 3rd and 4th arguments are differe

Re: [PATCH 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-14 Thread Amit Tomar
Hi Jaehoon Thanks for having a look and providing the comments Order to the bit number. Ok, Sure > > > + > > +#define OWL_MMC_OCR (MMC_VDD_32_33 | MMC_VDD_33_34 > | \ > > + MMC_VDD_165_195) > > + > > +#define DATA_TRANSFER_TIMEOUT

Re: [PATCH 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-14 Thread André Przywara
On 13/12/2020 10:08, Amit Singh Tomar wrote: > From: Amit Singh Tomar > > This commit adds support for MMC controllers found on Actions OWL > S700 SoC platform. > > Signed-off-by: Amit Singh Tomar > --- > drivers/mmc/Kconfig | 7 + > drivers/mmc/Makefile | 1 + > drivers/mmc/owl_mmc.c |

Re: [PATCH 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-13 Thread Jaehoon Chung
On 12/13/20 7:08 PM, Amit Singh Tomar wrote: > From: Amit Singh Tomar > > This commit adds support for MMC controllers found on Actions OWL > S700 SoC platform. > > Signed-off-by: Amit Singh Tomar > --- > drivers/mmc/Kconfig | 7 + > drivers/mmc/Makefile | 1 + > drivers/mmc/owl_mmc.c |

[PATCH 5/6] mmc: actions: add MMC driver for Actions OWL S700

2020-12-13 Thread Amit Singh Tomar
From: Amit Singh Tomar This commit adds support for MMC controllers found on Actions OWL S700 SoC platform. Signed-off-by: Amit Singh Tomar --- drivers/mmc/Kconfig | 7 + drivers/mmc/Makefile | 1 + drivers/mmc/owl_mmc.c | 404 ++ 3 files