Re: [PATCH 5/5] mtd: spi: Use IS_ENABLED to prevent ifdef

2020-05-15 Thread Rasmus Villemoes
On 15/05/2020 09.22, Rasmus Villemoes wrote: > That should make it obvious why one needs a variant that doesn't want > the CONFIG_ included in the argument; the CONFIG_IS_ENABLED macro needs > to do token-pasting with either CONFIG_SPL_ or just CONFIG_. On that note, I think all hits from git

Re: [PATCH 5/5] mtd: spi: Use IS_ENABLED to prevent ifdef

2020-05-15 Thread Rasmus Villemoes
On 15/05/2020 06.27, Stefan Roese wrote: > Hi Daniel, > > On 14.05.20 18:31, Daniel Schwierzeck wrote: >> >> >> Am 14.05.20 um 14:11 schrieb Jagan Teki: >>> Use IS_ENABLED to prevent ifdef in sf_probe.c >>> >>> Cc: Simon Glass >>> Cc: Vignesh R >>> Cc: Daniel Schwierzeck >>> Signed-off-by: Jaga

Re: [PATCH 5/5] mtd: spi: Use IS_ENABLED to prevent ifdef

2020-05-14 Thread Stefan Roese
Hi Daniel, On 14.05.20 18:31, Daniel Schwierzeck wrote: Am 14.05.20 um 14:11 schrieb Jagan Teki: Use IS_ENABLED to prevent ifdef in sf_probe.c Cc: Simon Glass Cc: Vignesh R Cc: Daniel Schwierzeck Signed-off-by: Jagan Teki --- drivers/mtd/spi/sf_internal.h | 10 ++ drivers/mtd/

Re: [PATCH 5/5] mtd: spi: Use IS_ENABLED to prevent ifdef

2020-05-14 Thread Daniel Schwierzeck
Am 14.05.20 um 14:11 schrieb Jagan Teki: > Use IS_ENABLED to prevent ifdef in sf_probe.c > > Cc: Simon Glass > Cc: Vignesh R > Cc: Daniel Schwierzeck > Signed-off-by: Jagan Teki > --- > drivers/mtd/spi/sf_internal.h | 10 ++ > drivers/mtd/spi/sf_probe.c| 17 - >

[PATCH 5/5] mtd: spi: Use IS_ENABLED to prevent ifdef

2020-05-14 Thread Jagan Teki
Use IS_ENABLED to prevent ifdef in sf_probe.c Cc: Simon Glass Cc: Vignesh R Cc: Daniel Schwierzeck Signed-off-by: Jagan Teki --- drivers/mtd/spi/sf_internal.h | 10 ++ drivers/mtd/spi/sf_probe.c| 17 - 2 files changed, 18 insertions(+), 9 deletions(-) diff --git a