Re: [PATCH 4/6] net: fec: add support for DM_MDIO

2022-04-01 Thread Vladimir Oltean
On Fri, Apr 01, 2022 at 10:53:14AM -0700, Tim Harvey wrote: > Can you review 'net: add MV88E61xx DSA driver' for me? I will. I've been thinking all day today about what to say that isn't stupid. Give me some time and I'll provide feedback.

Re: [PATCH 4/6] net: fec: add support for DM_MDIO

2022-04-01 Thread Tim Harvey
On Thu, Mar 31, 2022 at 12:36 PM Vladimir Oltean wrote: > > On Thu, Mar 31, 2022 at 10:48:55AM -0700, Tim Harvey wrote: > > > On which branch does this apply? The context above > > > fecmxc_read_rom_hwaddr() > > > is different in the branches I've checked: > > > https://source.denx.de/u-boot/u-bo

Re: [PATCH 4/6] net: fec: add support for DM_MDIO

2022-03-31 Thread Vladimir Oltean
On Thu, Mar 31, 2022 at 10:48:55AM -0700, Tim Harvey wrote: > > On which branch does this apply? The context above fecmxc_read_rom_hwaddr() > > is different in the branches I've checked: > > https://source.denx.de/u-boot/u-boot/-/blob/master/drivers/net/fec_mxc.c#L1276 > > https://source.denx.de/u-

Re: [PATCH 4/6] net: fec: add support for DM_MDIO

2022-03-31 Thread Tim Harvey
On Thu, Mar 31, 2022 at 10:01 AM Vladimir Oltean wrote: > > On Tue, Mar 29, 2022 at 03:52:38PM -0700, Tim Harvey wrote: > > Add support for DM_MDIO by registering a UCLASS_MDIO driver and > > attempting to use it. This is necessary if wanting to use a DSA > > driver for example hanging off of the

Re: [PATCH 4/6] net: fec: add support for DM_MDIO

2022-03-31 Thread Vladimir Oltean
On Tue, Mar 29, 2022 at 03:52:38PM -0700, Tim Harvey wrote: > Add support for DM_MDIO by registering a UCLASS_MDIO driver and > attempting to use it. This is necessary if wanting to use a DSA > driver for example hanging off of the FEC MAC. > > Care is taken to fallback to non DM_MDIO as several b

[PATCH 4/6] net: fec: add support for DM_MDIO

2022-03-29 Thread Tim Harvey
Add support for DM_MDIO by registering a UCLASS_MDIO driver and attempting to use it. This is necessary if wanting to use a DSA driver for example hanging off of the FEC MAC. Care is taken to fallback to non DM_MDIO as several boards define DM_MDIO without having the proper device-tree configurati